Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30731

Deprecated variables are not consistently highlighted

Details

    Description

      Deprecated variables should ideally

      • return a warning when they are modified
      • have their description updated

      This is only partially implemented. For example, of the variables marked as deprecated in the 11.0.1 release notes, innodb_file_per_table returns a warning when modified, but its description remains unmodified:

      set global innodb_file_per_table=0;
      		 
      Query OK, 0 rows affected, 1 warning (0.000 sec)
      		 
       
      		 
      Warning (Code 1287): '@@innodb_file_per_table' is deprecated and will 
        be removed in a future release
      		 
       
      		 
      mysql [localhost:11001] {msandbox} ((none)) > SELECT * FROM 
        INFORMATION_SCHEMA.SYSTEM_VARIABLES WHERE 
        VARIABLE_NAME LIKE 'innodb_file_per_t%'\G
      		 
      *************************** 1. row ***************************
      		 
              VARIABLE_NAME: INNODB_FILE_PER_TABLE
      		 
      ...
      		 
           VARIABLE_COMMENT: Stores each InnoDB table to an .ibd file in the database dir.
      		 
      ...

      However, innodb_defragment_n_pages for example does neither:

      set global innodb_defragment_n_pages=7;
      		 
      Query OK, 0 rows affected (0.000 sec)

      The descriptions should be adjusted and a warning returned in all cases to alert users that these variables are deprecated.

      Attachments

        Issue Links

          is blocked by

          New Feature - A new feature of the product, which has yet to be developed. MDEV-28671 Presentation of aliases in `mariadbd --verbose --help` is highly redundant

          • Major - Major loss of function.
          • Stalled
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-30332 PLUGIN_VAR_DEPRECATED fails to throw a warning on startup

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33503 innodb_log_files_in_group is quietly ignored

          • Major - Major loss of function.
          • Confirmed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä added a comment -

            greenman, this is strange. The flag PLUGIN_VAR_DEPRECATED was set for both innodb_file_per_table and innodb_defragment_n_pages in the 11.0 release.

            I wonder if a consistent documentation string adjustment could be part of MDEV-28671.

            marko Marko Mäkelä added a comment - greenman , this is strange. The flag PLUGIN_VAR_DEPRECATED was set for both innodb_file_per_table and innodb_defragment_n_pages in the 11.0 release. I wonder if a consistent documentation string adjustment could be part of MDEV-28671 .
            serg Sergei Golubchik added a comment -

            marko, yes, it should and will be

            serg Sergei Golubchik added a comment - marko , yes, it should and will be

            People

              serg Sergei Golubchik
              greenman Ian Gilfillan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.