[MDEV-30731] Deprecated variables are not consistently highlighted Created: 2023-02-27  Updated: 2023-09-12

Status: Open
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 11.0.1
Fix Version/s: 11.4

Type: Bug Priority: Major
Reporter: Ian Gilfillan Assignee: Sergei Golubchik
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Blocks
is blocked by MDEV-28671 Presentation of aliases in `mariadbd ... Stalled
Relates
relates to MDEV-30332 PLUGIN_VAR_DEPRECATED fails to throw ... Closed

 Description   

Deprecated variables should ideally

  • return a warning when they are modified
  • have their description updated

This is only partially implemented. For example, of the variables marked as deprecated in the 11.0.1 release notes, innodb_file_per_table returns a warning when modified, but its description remains unmodified:

set global innodb_file_per_table=0;
 
Query OK, 0 rows affected, 1 warning (0.000 sec)
 
 
 
Warning (Code 1287): '@@innodb_file_per_table' is deprecated and will 
  be removed in a future release
 
 
 
mysql [localhost:11001] {msandbox} ((none)) > SELECT * FROM 
  INFORMATION_SCHEMA.SYSTEM_VARIABLES WHERE 
  VARIABLE_NAME LIKE 'innodb_file_per_t%'\G
 
*************************** 1. row ***************************
 
        VARIABLE_NAME: INNODB_FILE_PER_TABLE
 
...
 
     VARIABLE_COMMENT: Stores each InnoDB table to an .ibd file in the database dir.
 
...

However, innodb_defragment_n_pages for example does neither:

set global innodb_defragment_n_pages=7;
 
Query OK, 0 rows affected (0.000 sec)

The descriptions should be adjusted and a warning returned in all cases to alert users that these variables are deprecated.

 Comments   
Comment by Marko Mäkelä [ 2023-02-27 ]

greenman, this is strange. The flag PLUGIN_VAR_DEPRECATED was set for both innodb_file_per_table and innodb_defragment_n_pages in the 11.0 release.

I wonder if a consistent documentation string adjustment could be part of MDEV-28671.

Comment by Sergei Golubchik [ 2023-03-26 ]

marko, yes, it should and will be

Generated at Thu Feb 08 10:18:29 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.