Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30630

locale: Chinese error message for ZH_CN

Details

    Description

      We've got a good compliment of Chinese error messages thanks to #2100 (MDEV-28227).

      So do we make it default for those in the ZH_

      {CN,TW,HK}

      locale?

      Attachments

        Issue Links

          Activity

            danblack Daniel Black added a comment - https://github.com/MariaDB/server/pull/2487 What do you think?

            danblack, can you please talk to a native Chinese speaker if our Chinese translation (presumable Simplified) is really good for TW and HK locales? Taiwan and Honk-Kong use Traditional Chinese for my knowledge.

            bar Alexander Barkov added a comment - danblack , can you please talk to a native Chinese speaker if our Chinese translation (presumable Simplified) is really good for TW and HK locales? Taiwan and Honk-Kong use Traditional Chinese for my knowledge.
            haidong Haidong Ji added a comment -

            I'm a native Chinese speaker and did most of the Chinese error message translation work. Yes, it is in simplified characters.

            For the most part, native Chinese speakers (whether from Mainland, HK, TW, or even Singapore) can read both simplified and traditional Chinese characters. However, if the host system is of HK/TW locale, usually I'd expect all info/error messages should be in traditional characters. So MariaDB displaying simplified characters on such a system may give the feeling of inconsistency.

            For consistency's sake, I suggest we not make this change. When I have time, I'd be happy to convert the simplified Chinese into traditional Chinese. After that, we can make HK/TW use that.

            Side note on Singapore: Chinese is the official language and I believe it uses simplified, but since English is also the official language, it probably does not need this.

            haidong Haidong Ji added a comment - I'm a native Chinese speaker and did most of the Chinese error message translation work. Yes, it is in simplified characters. For the most part, native Chinese speakers (whether from Mainland, HK, TW, or even Singapore) can read both simplified and traditional Chinese characters. However, if the host system is of HK/TW locale, usually I'd expect all info/error messages should be in traditional characters. So MariaDB displaying simplified characters on such a system may give the feeling of inconsistency. For consistency's sake, I suggest we not make this change. When I have time, I'd be happy to convert the simplified Chinese into traditional Chinese. After that, we can make HK/TW use that. Side note on Singapore: Chinese is the official language and I believe it uses simplified, but since English is also the official language, it probably does not need this.
            bar Alexander Barkov added a comment - - edited

            Hello haidong. Thank you for the information (and for contributing to MariaDB)!

            Do you think it's OK to bind Simplified Chinese error messages to MariaDB ZH_CN locale right now?
            Everything seems to be ready for it.

            Later when the Traditional Chinese translation is ready, we can bind the Traditional translation to ZH_HK and ZH_TW locales.
            Does this plan sound good? Thanks.

            bar Alexander Barkov added a comment - - edited Hello haidong . Thank you for the information (and for contributing to MariaDB)! Do you think it's OK to bind Simplified Chinese error messages to MariaDB ZH_CN locale right now? Everything seems to be ready for it. Later when the Traditional Chinese translation is ready, we can bind the Traditional translation to ZH_HK and ZH_TW locales. Does this plan sound good? Thanks.
            haidong Haidong Ji added a comment -

            You are very welcome, @Alexander Barkov.

            > Do you think it's OK to bind Simplified Chinese error messages to MariaDB ZH_CN locale right now?
            Yes, I think that sounded like a safe and right thing to do.

            And yes, when Traditional Chinese translation is ready, we can do the same.

            haidong Haidong Ji added a comment - You are very welcome, @Alexander Barkov. > Do you think it's OK to bind Simplified Chinese error messages to MariaDB ZH_CN locale right now? Yes, I think that sounded like a safe and right thing to do. And yes, when Traditional Chinese translation is ready, we can do the same.
            danblack Daniel Black added a comment - Thanks haidong . https://github.com/MariaDB/server/pull/2499

            Hi danblack,

            the patch
            https://github.com/MariaDB/server/pull/2499/commits/c6fcc0e41137ae9039169807680124ba04b38b5d
            looks OK.

            One small note: can you please add a test that after setting lc_messages=ZH_CN error messaging really switches to Chinese.

            Something like this should be enough:

            SET lc_messages=ZH_CN;
            SELECT x;
            

            Thanks!

            bar Alexander Barkov added a comment - Hi danblack , the patch https://github.com/MariaDB/server/pull/2499/commits/c6fcc0e41137ae9039169807680124ba04b38b5d looks OK. One small note: can you please add a test that after setting lc_messages=ZH_CN error messaging really switches to Chinese. Something like this should be enough: SET lc_messages=ZH_CN; SELECT x; Thanks!

            People

              danblack Daniel Black
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.