[MDEV-30630] locale: Chinese error message for ZH_CN Created: 2023-02-09  Updated: 2023-02-15  Resolved: 2023-02-15

Status: Closed
Project: MariaDB Server
Component/s: Locale Settings
Affects Version/s: 10.11
Fix Version/s: 10.11.2, 11.0.1, 10.4.29, 10.5.20, 10.6.13, 10.8.8, 10.9.6, 10.10.4

Type: Bug Priority: Major
Reporter: Daniel Black Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-28227 Error message Chinese translation Closed

 Description   

We've got a good compliment of Chinese error messages thanks to #2100 (MDEV-28227).

So do we make it default for those in the ZH_

{CN,TW,HK}

locale?



 Comments   
Comment by Daniel Black [ 2023-02-09 ]

https://github.com/MariaDB/server/pull/2487

What do you think?

Comment by Alexander Barkov [ 2023-02-10 ]

danblack, can you please talk to a native Chinese speaker if our Chinese translation (presumable Simplified) is really good for TW and HK locales? Taiwan and Honk-Kong use Traditional Chinese for my knowledge.

Comment by Haidong Ji [ 2023-02-11 ]

I'm a native Chinese speaker and did most of the Chinese error message translation work. Yes, it is in simplified characters.

For the most part, native Chinese speakers (whether from Mainland, HK, TW, or even Singapore) can read both simplified and traditional Chinese characters. However, if the host system is of HK/TW locale, usually I'd expect all info/error messages should be in traditional characters. So MariaDB displaying simplified characters on such a system may give the feeling of inconsistency.

For consistency's sake, I suggest we not make this change. When I have time, I'd be happy to convert the simplified Chinese into traditional Chinese. After that, we can make HK/TW use that.

Side note on Singapore: Chinese is the official language and I believe it uses simplified, but since English is also the official language, it probably does not need this.

Comment by Alexander Barkov [ 2023-02-14 ]

Hello haidong. Thank you for the information (and for contributing to MariaDB)!

Do you think it's OK to bind Simplified Chinese error messages to MariaDB ZH_CN locale right now?
Everything seems to be ready for it.

Later when the Traditional Chinese translation is ready, we can bind the Traditional translation to ZH_HK and ZH_TW locales.
Does this plan sound good? Thanks.

Comment by Haidong Ji [ 2023-02-14 ]

You are very welcome, @Alexander Barkov.

> Do you think it's OK to bind Simplified Chinese error messages to MariaDB ZH_CN locale right now?
Yes, I think that sounded like a safe and right thing to do.

And yes, when Traditional Chinese translation is ready, we can do the same.

Comment by Daniel Black [ 2023-02-14 ]

Thanks haidong.

https://github.com/MariaDB/server/pull/2499

Comment by Alexander Barkov [ 2023-02-15 ]

Hi danblack,

the patch
https://github.com/MariaDB/server/pull/2499/commits/c6fcc0e41137ae9039169807680124ba04b38b5d
looks OK.

One small note: can you please add a test that after setting lc_messages=ZH_CN error messaging really switches to Chinese.

Something like this should be enough:

SET lc_messages=ZH_CN;
SELECT x;

Thanks!

Generated at Thu Feb 08 10:17:42 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.