Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30435

Fix code duplication w.r.t. memcpy in spd_trx.cc

Details

    Attachments

      Issue Links

        blocks

        Bug - A problem which impairs or prevents the functions of the product. MDEV-30981 Spider UBSAN: null pointer passed as argument 2, which is declared to never be null in spider_create_trx_alter_table on ALTER

        • Major - Major loss of function.
        • Closed

        Activity

          Ascending order - Click to sort in descending order
          ycp Yuchen Pei created issue -
          ycp Yuchen Pei made changes -
          Field Original Value New Value
          Epic Link MDEV-26286 [ 101691 ]
          ycp Yuchen Pei made changes -
          ycp Yuchen Pei made changes -
          Description Suggested by [~holyfoot] in a review for MDEV-26541. Suggested by [~holyfoot] in a review for MDEV-26541.

          This will also fix similar ubsan complaints as in https://jira.mariadb.org/browse/MDEV-26541?focusedCommentId=246967&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-246967
          ycp Yuchen Pei made changes -
          Priority Minor [ 4 ] Major [ 3 ]
          ycp Yuchen Pei made changes -
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.9 [ 26905 ]
          Fix Version/s 10.10 [ 27530 ]
          Fix Version/s 10.11 [ 27614 ]
          Fix Version/s 11.0 [ 28320 ]
          Fix Version/s 11.1 [ 28549 ]
          ycp Yuchen Pei made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          ycp Yuchen Pei added a comment -

          Hi holyfoot, PTAL thanks:

          https://github.com/MariaDB/server/commit/fae069c53b3

          ycp Yuchen Pei added a comment - Hi holyfoot , PTAL thanks: https://github.com/MariaDB/server/commit/fae069c53b3
          ycp Yuchen Pei made changes -
          Assignee Yuchen Pei [ JIRAUSER52627 ] Alexey Botchkov [ holyfoot ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          holyfoot Alexey Botchkov added a comment -

          ok to push.

          holyfoot Alexey Botchkov added a comment - ok to push.
          holyfoot Alexey Botchkov made changes -
          Assignee Alexey Botchkov [ holyfoot ] Yuchen Pei [ JIRAUSER52627 ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          ycp Yuchen Pei added a comment -

          Thanks for the review, pushed to 10.4

          ycp Yuchen Pei added a comment - Thanks for the review, pushed to 10.4
          ycp Yuchen Pei made changes -
          Fix Version/s 10.4.30 [ 28912 ]
          Fix Version/s 10.5.21 [ 28913 ]
          Fix Version/s 10.6.14 [ 28914 ]
          Fix Version/s 10.9.7 [ 28916 ]
          Fix Version/s 10.10.5 [ 28917 ]
          Fix Version/s 10.11.4 [ 28918 ]
          Fix Version/s 11.0.3 [ 28920 ]
          Fix Version/s 11.1.2 [ 28921 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.9 [ 26905 ]
          Fix Version/s 10.10 [ 27530 ]
          Fix Version/s 10.11 [ 27614 ]
          Fix Version/s 11.0 [ 28320 ]
          Fix Version/s 11.1 [ 28549 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          dbart Daniel Bartholomew made changes -
          Fix Version/s 10.4.31 [ 29010 ]
          Fix Version/s 10.5.22 [ 29011 ]
          Fix Version/s 10.6.15 [ 29013 ]
          Fix Version/s 10.9.8 [ 29015 ]
          Fix Version/s 10.10.6 [ 29017 ]
          Fix Version/s 10.11.5 [ 29019 ]
          dbart Daniel Bartholomew made changes -
          Fix Version/s 10.4.30 [ 28912 ]
          Fix Version/s 10.5.21 [ 28913 ]
          Fix Version/s 10.6.14 [ 28914 ]
          Fix Version/s 10.9.7 [ 28916 ]
          Fix Version/s 10.10.5 [ 28917 ]
          Fix Version/s 10.11.4 [ 28918 ]

          People

            ycp Yuchen Pei
            ycp Yuchen Pei
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.