Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.3(EOL)
-
None
Description
According to the documentation of rpl_semi_sync_slave, this option is removed and indeed -result
show variables like 'rpl_semi_sync_slave%'; |
Variable_name Value
|
rpl_semi_sync_slave_delay_master OFF |
rpl_semi_sync_slave_enabled OFF |
rpl_semi_sync_slave_kill_conn_timeout 5
|
rpl_semi_sync_slave_trace_level 32
|
However there is usage of this variable in functions is_semi_sync_slave() and Repl_semi_sync_slave::request_transmit()
inline bool is_semi_sync_slave()
|
{
|
int null_value;
|
long long val= 0;
|
get_user_var_int("rpl_semi_sync_slave", &val, &null_value);
|
return val;
|
}
|
It should be changed with rpl_semi_sync_slave_enabled (KB)see Repl_semi_sync_slave::init_object().
Attachments
Issue Links
- relates to
-
MDEV-13073 AliSQL: [Performance] Issue #40 Optimize performance of semisync
-
- Closed
-
- links to
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | Remove rpl_semi_sync_slave variable | Remove rpl_semi_sync_slave usage in code |
| Description |
According to the documentation of [rpl_semi_sync_slave|https://mariadb.com/kb/en/semisynchronous-replication/#rpl_semi_sync_slave], this option is removed and indeed -[result|https://dbfiddle.uk/HxFZFJKK]
{code:sql} show variables like 'rpl_semi_sync_slave%'; Variable_name Value rpl_semi_sync_slave_delay_master OFF rpl_semi_sync_slave_enabled OFF rpl_semi_sync_slave_kill_conn_timeout 5 rpl_semi_sync_slave_trace_level 32 {code} However there is usage of this variable in functions {{is_semi_sync_slave()}} and {{Repl_semi_sync_slave::request_transmit()}} {code:C} inline bool is_semi_sync_slave() { int null_value; long long val= 0; get_user_var_int("rpl_semi_sync_slave", &val, &null_value); return val; } {code} It should be changed with {{rpl_semi_sync_slave_enabled}} see {{Repl_semi_sync_slave::init_object()}}. |
According to the documentation of [rpl_semi_sync_slave|https://mariadb.com/kb/en/semisynchronous-replication/#rpl_semi_sync_slave], this option is removed and indeed -[result|https://dbfiddle.uk/HxFZFJKK]
{code:sql} show variables like 'rpl_semi_sync_slave%'; Variable_name Value rpl_semi_sync_slave_delay_master OFF rpl_semi_sync_slave_enabled OFF rpl_semi_sync_slave_kill_conn_timeout 5 rpl_semi_sync_slave_trace_level 32 {code} However there is usage of this variable in functions {{is_semi_sync_slave()}} and {{Repl_semi_sync_slave::request_transmit()}} {code:C} inline bool is_semi_sync_slave() { int null_value; long long val= 0; get_user_var_int("rpl_semi_sync_slave", &val, &null_value); return val; } {code} It should be changed with {{rpl_semi_sync_slave_enabled}} ([KB|https://mariadb.com/kb/en/semisynchronous-replication/#rpl_semi_sync_slave_enabled])see {{Repl_semi_sync_slave::init_object()}}. |
| Assignee | Brandon Nesterenko [ JIRAUSER48702 ] | Anel Husakovic [ anel ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Link |
This issue relates to |
| Summary | Remove rpl_semi_sync_slave usage in code | Remove rpl_semi_sync_[master,slave] plugin keyword usage in code |
| Remote Link | This issue links to "PR 2528 (Web Link)" [ 34957 ] |
| Assignee | Anel Husakovic [ anel ] | Brandon Nesterenko [ JIRAUSER48702 ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Assignee | Brandon Nesterenko [ JIRAUSER48702 ] | Anel Husakovic [ anel ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Fix Version/s | 10.4.29 [ 28510 ] | |
| Fix Version/s | 10.5.20 [ 28512 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |