[MDEV-30269] Remove rpl_semi_sync_[master,slave] plugin keyword usage in code Created: 2022-12-19  Updated: 2023-03-23  Resolved: 2023-03-23

Status: Closed
Project: MariaDB Server
Component/s: Replication, Server
Affects Version/s: 10.3
Fix Version/s: 10.4.29, 10.5.20

Type: Bug Priority: Major
Reporter: Anel Husakovic Assignee: Anel Husakovic
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-13073 AliSQL: [Performance] Issue #40 Optim... Closed

 Description   

According to the documentation of rpl_semi_sync_slave, this option is removed and indeed -result

show variables like 'rpl_semi_sync_slave%';
 
Variable_name	Value
 
rpl_semi_sync_slave_delay_master	OFF
 
rpl_semi_sync_slave_enabled	OFF
 
rpl_semi_sync_slave_kill_conn_timeout	5
 
rpl_semi_sync_slave_trace_level	32

However there is usage of this variable in functions is_semi_sync_slave() and Repl_semi_sync_slave::request_transmit()

inline bool is_semi_sync_slave()
 
{
 
  int null_value;
 
  long long val= 0;
 
  get_user_var_int("rpl_semi_sync_slave", &val, &null_value);
 
  return val;
 
}

It should be changed with rpl_semi_sync_slave_enabled (KB)see Repl_semi_sync_slave::init_object().

 Comments   
Comment by Anel Husakovic [ 2023-02-27 ]

bnestere can you please confirm the bug?
I will assign to myself to fix it.

Comment by Brandon Nesterenko [ 2023-02-27 ]

Indeed, I agree. Can you investigate rpl_semi_sync_master as well? I also see it as removed in the documentation, yet I see it used in mysql-test/suite/sys_vars/t/all_vars.test (same with slave).

Comment by Brandon Nesterenko [ 2023-03-21 ]

Reviewed PRs 2528 and 2380 with the suggestion to combine them, otherwise they both look good.

Generated at Thu Feb 08 10:14:59 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.