Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30269

Remove rpl_semi_sync_[master,slave] plugin keyword usage in code

    XMLWordPrintable

Details

    Description

      According to the documentation of rpl_semi_sync_slave, this option is removed and indeed -result

      show variables like 'rpl_semi_sync_slave%';
      Variable_name	Value
      rpl_semi_sync_slave_delay_master	OFF
      rpl_semi_sync_slave_enabled	OFF
      rpl_semi_sync_slave_kill_conn_timeout	5
      rpl_semi_sync_slave_trace_level	32
      

      However there is usage of this variable in functions is_semi_sync_slave() and Repl_semi_sync_slave::request_transmit()

      inline bool is_semi_sync_slave()
      {
        int null_value;
        long long val= 0;
        get_user_var_int("rpl_semi_sync_slave", &val, &null_value);
        return val;
      }
      

      It should be changed with rpl_semi_sync_slave_enabled (KB)see Repl_semi_sync_slave::init_object().

      Attachments

        Issue Links

          Activity

            People

              anel Anel Husakovic
              anel Anel Husakovic
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.