Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.3(EOL)
-
None
Description
According to the documentation of rpl_semi_sync_slave, this option is removed and indeed -result
show variables like 'rpl_semi_sync_slave%'; |
Variable_name Value
|
rpl_semi_sync_slave_delay_master OFF |
rpl_semi_sync_slave_enabled OFF |
rpl_semi_sync_slave_kill_conn_timeout 5
|
rpl_semi_sync_slave_trace_level 32
|
However there is usage of this variable in functions is_semi_sync_slave() and Repl_semi_sync_slave::request_transmit()
inline bool is_semi_sync_slave()
|
{
|
int null_value;
|
long long val= 0;
|
get_user_var_int("rpl_semi_sync_slave", &val, &null_value);
|
return val;
|
}
|
It should be changed with rpl_semi_sync_slave_enabled (KB)see Repl_semi_sync_slave::init_object().
Attachments
Issue Links
- relates to
-
MDEV-13073 AliSQL: [Performance] Issue #40 Optimize performance of semisync
-
- Closed
-
- links to
Activity
Indeed, I agree. Can you investigate rpl_semi_sync_master as well? I also see it as removed in the documentation, yet I see it used in mysql-test/suite/sys_vars/t/all_vars.test (same with slave).
Reviewed PRs 2528 and 2380 with the suggestion to combine them, otherwise they both look good.
bnestere can you please confirm the bug?
I will assign to myself to fix it.