Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29982

Improve the InnoDB log overwrite error message

Details

    Description

      Related to MDEV-29905 it has been discussed that the error message for change buffer merge errors, like 

      2022-10-24 23:58:25 0 [ERROR] InnoDB: The age of the last checkpoint is 991661268, which exceeds the log capacity 966365799.

      should be changed to avoid that the user is killing the shutdown process because of this error message and a long running shutdown.

      The error message should be changed to

      2022-10-24 23:58:25 0 [ERROR] InnoDB: The age of the last checkpoint is 991661268, which exceeds the log capacity 966365799. Shutdown is still in progress.

      We also should add a second message 

      [Note] InnoDB: Corruption fixed by log checkpoint at LSN=xxxxx

      as "end of fatal condition" message

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27784 log_overwrite_warning displays an error instead of a warning

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29905 Change buffer operations fail to check for log file overflow

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33670 Redo log overwritten/corrupted

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-34566 InnoDB: Crash recovery is broken due to insufficient innodb_log_file_size (but wasn't in crash recovery)

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            tychy Ryu Yamada added a comment -

            I'll be obliged if you'd review my PR, hope it's not much mistaken...
            https://github.com/MariaDB/server/pull/2328

            tychy Ryu Yamada added a comment - I'll be obliged if you'd review my PR, hope it's not much mistaken... https://github.com/MariaDB/server/pull/2328
            marko Marko Mäkelä added a comment -

            I am going to implement messages like this:

            [ERROR] InnoDB: Crash recovery is broken due to insufficient innodb_log_file_size; last checkpoint LSN=WWW, current LSN=YYY. Shutdown is in progress.
            		 
            [Note] InnoDB: InnoDB: Crash recovery was broken between LSN=XXX and checkpoint LSN=ZZZ.

            For the log sequence numbers, WWW<XXX<YYY<ZZZ should hold. The phrase "Shutdown is in progress." will only be output if shutdown has actually been initiated.

            I must come up with some debug instrumentation so that these messages can be exercised in our regression test suite.

            marko Marko Mäkelä added a comment - I am going to implement messages like this: [ERROR] InnoDB: Crash recovery is broken due to insufficient innodb_log_file_size; last checkpoint LSN=WWW, current LSN=YYY. Shutdown is in progress. [Note] InnoDB: InnoDB: Crash recovery was broken between LSN=XXX and checkpoint LSN=ZZZ. For the log sequence numbers, WWW<XXX<YYY<ZZZ should hold. The phrase "Shutdown is in progress." will only be output if shutdown has actually been initiated. I must come up with some debug instrumentation so that these messages can be exercised in our regression test suite.

            People

              marko Marko Mäkelä
              ralf.gebhardt Ralf Gebhardt
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.