[MDEV-29982] Improve the InnoDB log overwrite error message Created: 2022-11-09  Updated: 2022-11-23  Resolved: 2022-11-14

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10
Fix Version/s: 10.11.2, 10.5.19, 10.6.12, 10.7.8, 10.8.7, 10.9.5, 10.10.3

Type: Bug Priority: Major
Reporter: Ralf Gebhardt Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: corruption, shutdown

Issue Links:
Blocks
Relates
relates to MDEV-27784 log_overwrite_warning displays an err... Closed
relates to MDEV-29905 Change buffer operations fail to chec... Closed

 Description   

Related to MDEV-29905 it has been discussed that the error message for change buffer merge errors, like 

2022-10-24 23:58:25 0 [ERROR] InnoDB: The age of the last checkpoint is 991661268, which exceeds the log capacity 966365799.

should be changed to avoid that the user is killing the shutdown process because of this error message and a long running shutdown.

The error message should be changed to

2022-10-24 23:58:25 0 [ERROR] InnoDB: The age of the last checkpoint is 991661268, which exceeds the log capacity 966365799. Shutdown is still in progress.

We also should add a second message 

[Note] InnoDB: Corruption fixed by log checkpoint at LSN=xxxxx

as "end of fatal condition" message

 Comments   
Comment by Ryu Yamada [ 2022-11-09 ]

I'll be obliged if you'd review my PR, hope it's not much mistaken...
https://github.com/MariaDB/server/pull/2328

Comment by Marko Mäkelä [ 2022-11-14 ]

I am going to implement messages like this:

[ERROR] InnoDB: Crash recovery is broken due to insufficient innodb_log_file_size; last checkpoint LSN=WWW, current LSN=YYY. Shutdown is in progress.
 
[Note] InnoDB: InnoDB: Crash recovery was broken between LSN=XXX and checkpoint LSN=ZZZ.

For the log sequence numbers, WWW<XXX<YYY<ZZZ should hold. The phrase "Shutdown is in progress." will only be output if shutdown has actually been initiated.

I must come up with some debug instrumentation so that these messages can be exercised in our regression test suite.

Generated at Thu Feb 08 10:12:45 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.