[MDEV-29718] Spider: variable spider_same_server_link not functioning correctly - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL), 10.11
Fix Version/s: 10.4.33, 10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4, 11.2.3
Component/s: Storage Engine - Spider
Labels:
None

Description

With thanks to elenst and nayuta-yanagisawa.

In principle, it should not be possible to make a connection to the same local instance without setting spider_same_server_link to 1.

However, as seen in several recent bugs, it is possible to create a socket (and possibly a tcp) connection to the same local instance with this variable still set to 0/off (the default).

As a sidethought, when this is fixed, any testcase which does not have spider_same_server_link=1 set, may need to be updated.

Relevant code:

    if (!spider_param_same_server_link(thd))

      if (!strcmp(tgt_host, my_localhost))

        if (!strcmp(tgt_socket, *spd_mysqld_unix_port))

          my_printf_error(ER_SPIDER_SAME_SERVER_LINK_NUM,

            ER_SPIDER_SAME_SERVER_LINK_STR1, MYF(0),

            tgt_host, tgt_socket);

          DBUG_RETURN(ER_SPIDER_SAME_SERVER_LINK_NUM);

      } else if (!strcmp(tgt_host, "127.0.0.1") ||

        !strcmp(tgt_host, glob_hostname))

        if (tgt_port == (long) *spd_mysqld_port)

          my_printf_error(ER_SPIDER_SAME_SERVER_LINK_NUM,

            ER_SPIDER_SAME_SERVER_LINK_STR2, MYF(0),

            tgt_host, tgt_port);

          DBUG_RETURN(ER_SPIDER_SAME_SERVER_LINK_NUM);

Attachments

Activity

People

Assignee:: Yuchen Pei

Reporter:: Roel Van de Paar

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2022-10-05 21:37

Updated:: 2024-05-13 04:51

Resolved:: 2024-01-10 07:06

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server