[MDEV-29612] ReadViewBase::snapshot() misses an optimization - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.5, 10.6, 10.3(EOL), 10.4(EOL), 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL)
Fix Version/s: 10.6.11, 10.7.7, 10.8.6, 10.9.4, 10.10.2, 10.11.1
Component/s: Storage Engine - InnoDB
Labels:
- performance

Description

While debugging ~~MDEV-24402~~, I came across the following in ReadViewBase::snapshot():

(rr) p *this

$1 = {m_low_limit_id = 317, m_up_limit_id = 315, m_ids = std::vector of length 2, capacity 34 = {315, 316}, m_low_limit_no = 317}

This is equivalent to a read view where m_ids is empty and all other fields are 315.

An empty m_ids should make ReadViewBase::changes_visible() and ReadViewBase::append() faster.

Attachments

Issue Links

relates to

MDEV-15104 Remove trx_sys_t::rw_trx_ids and trx_sys_t::serialisation_list

Closed

MDEV-22593 InnoDB: don't take trx_sys.mutex in ReadView::open()

Closed

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 1 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2022-09-23 07:04

Updated:: 2022-10-06 11:43

Resolved:: 2022-10-06 11:43

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.