Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29612

ReadViewBase::snapshot() misses an optimization

    XMLWordPrintable

    Details

      Description

      While debugging MDEV-24402, I came across the following in ReadViewBase::snapshot():

      (rr) p *this
      $1 = {m_low_limit_id = 317, m_up_limit_id = 315, m_ids = std::vector of length 2, capacity 34 = {315, 316}, m_low_limit_no = 317}
      

      This is equivalent to a read view where m_ids is empty and all other fields are 315.

      An empty m_ids should make ReadViewBase::changes_visible() and ReadViewBase::append() faster.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marko Marko Mäkelä
              Reporter:
              marko Marko Mäkelä
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.