Type:
Bug
Priority:
Critical
Resolution:
Fixed
Affects Version/s:
10.4(EOL) , 10.5 , 10.6 , 10.7(EOL) , 10.8(EOL) , 10.10(EOL) , 10.11
trx->mysql_thd can be zeroed-out between thd_get_thread_id() and thd_query_safe() calls in fill_trx_row(). trx_disconnect_prepared() zeroes out trx->mysql_thd. And this can cause null pointer dereferencing in fill_trx_row().
The bug can be reproduced with the following new sync point:
diff --git a/storage/innobase/trx/trx0i_s.cc b/storage/innobase/trx/trx0i_s.cc
index 2dc39118d3d..c2cc8c970b0 100644
--- a/storage/innobase/trx/trx0i_s.cc
+++ b/storage/innobase/trx/trx0i_s.cc
@@ - 461 , 6 + 461 , 8 @@ fill_trx_row(
row->trx_mysql_thread_id = thd_get_thread_id(trx->mysql_thd);
char query[TRX_I_S_TRX_QUERY_MAX_LEN + 1 ];
+ ut_d( if (trx->state == TRX_STATE_PREPARED)
+ DEBUG_SYNC_C( "fill_trx_row_before_query_request" ));
if (size_t stmt_len = thd_query_safe(trx->mysql_thd, query,
sizeof query)) {
row->trx_query = static_cast< const char *>(
diff --git a/storage/innobase/trx/trx0trx.cc b/storage/innobase/trx/trx0trx.cc
index 3b19d213d5a..92bf9de375a 100644
--- a/storage/innobase/trx/trx0trx.cc
+++ b/storage/innobase/trx/trx0trx.cc
@@ - 550 , 6 + 550 , 7 @@ void trx_disconnect_prepared(trx_t *trx)
trx->read_view.close();
trx->is_recovered= true ;
trx->mysql_thd= NULL;
+ DEBUG_SYNC_C( "trx_disconnect_prepared_reset_thd" );
/* todo/fixme: suggest to do it at innodb prepare */
trx->will_lock= false ;
trx_sys.rw_trx_hash.put_pins(trx);
and the following test case:
--source include/have_innodb.inc
--source include/have_debug.inc
--source include/have_debug_sync.inc
--source include/count_sessions.inc
--connection default
create table t (a int ) engine=innodb;
insert into t values( 1 );
--connect (con_xa, localhost, root,,)
SET DEBUG_SYNC= "trx_disconnect_prepared_reset_thd SIGNAL thd_reset" ;
xa start '1' ;
insert into t values( 1 );
xa end '1' ;
xa prepare '1' ;
--connection default
SET DEBUG_SYNC= "fill_trx_row_before_query_request SIGNAL reached WAIT_FOR fill_row_cont" ;
--send select * from information_schema.innodb_trx;
--connect (con_sync, localhost, root,,)
SET DEBUG_SYNC= "now WAIT_FOR reached" ;
--disconnect con_xa
SET DEBUG_SYNC= "now WAIT_FOR thd_reset" ;
SET DEBUG_SYNC= "now SIGNAL fill_row_cont" ;
--disconnect con_sync
--connection default
--disable_result_log
# Must crash here with SIGSEGV if not fixed
--reap;
--enable_result_log
xa commit '1' ;
drop table t;
SET DEBUG_SYNC= "RESET" ;
--source include/wait_until_count_sessions.inc
It does not affect 10.3 as 10.3 does not detach XA on disconnection (compare THD::cleanup() in 10.3 and 10.4+ and see trans_xa_detach() in 10.4+ for details).
Until MDEV-29368 is fixed the workaround is not to use innodb_trx, innodb_locks and innodb_lock_waits from information_schema along with detached XA's.
{"report":{"fcp":874.1999998092651,"ttfb":360.5,"pageVisibility":"visible","entityId":114800,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"bd281bf1-80f9-43b7-9ec9-a9ba5a2089cb","navigationType":0,"readyForUser":1011.5,"redirectCount":0,"resourceLoadedEnd":874.9000005722046,"resourceLoadedStart":365.5,"resourceTiming":[{"duration":29,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":365.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":365.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":394.5,"responseStart":0,"secureConnectionStart":0},{"duration":34.10000038146973,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":365.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":365.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":399.9000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":96.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":365.9000005722046,"connectEnd":365.9000005722046,"connectStart":365.9000005722046,"domainLookupEnd":365.9000005722046,"domainLookupStart":365.9000005722046,"fetchStart":365.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":365.9000005722046,"responseEnd":462.1000003814697,"responseStart":462.1000003814697,"secureConnectionStart":365.9000005722046},{"duration":173.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":366,"connectEnd":366,"connectStart":366,"domainLookupEnd":366,"domainLookupStart":366,"fetchStart":366,"redirectEnd":0,"redirectStart":0,"requestStart":366,"responseEnd":539.6999998092651,"responseStart":539.6999998092651,"secureConnectionStart":366},{"duration":177.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":366.19999980926514,"connectEnd":366.19999980926514,"connectStart":366.19999980926514,"domainLookupEnd":366.19999980926514,"domainLookupStart":366.19999980926514,"fetchStart":366.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":366.19999980926514,"responseEnd":543.5,"responseStart":543.5,"secureConnectionStart":366.19999980926514},{"duration":177.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":366.19999980926514,"connectEnd":366.19999980926514,"connectStart":366.19999980926514,"domainLookupEnd":366.19999980926514,"domainLookupStart":366.19999980926514,"fetchStart":366.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":366.19999980926514,"responseEnd":544,"responseStart":544,"secureConnectionStart":366.19999980926514},{"duration":178.39999961853027,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":366.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":366.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":544.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":178,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":366.30000019073486,"connectEnd":366.30000019073486,"connectStart":366.30000019073486,"domainLookupEnd":366.30000019073486,"domainLookupStart":366.30000019073486,"fetchStart":366.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":366.30000019073486,"responseEnd":544.3000001907349,"responseStart":544.3000001907349,"secureConnectionStart":366.30000019073486},{"duration":178.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":366.5,"connectEnd":366.5,"connectStart":366.5,"domainLookupEnd":366.5,"domainLookupStart":366.5,"fetchStart":366.5,"redirectEnd":0,"redirectStart":0,"requestStart":366.5,"responseEnd":544.6999998092651,"responseStart":544.6999998092651,"secureConnectionStart":366.5},{"duration":178.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":366.6000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":366.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":545.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":178.60000038146973,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":366.69999980926514,"connectEnd":366.69999980926514,"connectStart":366.69999980926514,"domainLookupEnd":366.69999980926514,"domainLookupStart":366.69999980926514,"fetchStart":366.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":366.69999980926514,"responseEnd":545.3000001907349,"responseStart":545.3000001907349,"secureConnectionStart":366.69999980926514},{"duration":468.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":372.9000005722046,"connectEnd":372.9000005722046,"connectStart":372.9000005722046,"domainLookupEnd":372.9000005722046,"domainLookupStart":372.9000005722046,"fetchStart":372.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":372.9000005722046,"responseEnd":841.4000005722046,"responseStart":841.4000005722046,"secureConnectionStart":372.9000005722046},{"duration":500.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":374.19999980926514,"connectEnd":374.19999980926514,"connectStart":374.19999980926514,"domainLookupEnd":374.19999980926514,"domainLookupStart":374.19999980926514,"fetchStart":374.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":374.19999980926514,"responseEnd":874.9000005722046,"responseStart":874.9000005722046,"secureConnectionStart":374.19999980926514},{"duration":165.89999961853027,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":677.4000005722046,"connectEnd":677.4000005722046,"connectStart":677.4000005722046,"domainLookupEnd":677.4000005722046,"domainLookupStart":677.4000005722046,"fetchStart":677.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":677.4000005722046,"responseEnd":843.3000001907349,"responseStart":843.3000001907349,"secureConnectionStart":677.4000005722046},{"duration":50.30000019073486,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":852.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":852.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":902.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":186.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":929.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":929.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1115.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":185.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":930.1999998092651,"connectEnd":930.1999998092651,"connectStart":930.1999998092651,"domainLookupEnd":930.1999998092651,"domainLookupStart":930.1999998092651,"fetchStart":930.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":930.1999998092651,"responseEnd":1115.9000005722046,"responseStart":1115.9000005722046,"secureConnectionStart":930.1999998092651},{"duration":189.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":930.6999998092651,"connectEnd":930.6999998092651,"connectStart":930.6999998092651,"domainLookupEnd":930.6999998092651,"domainLookupStart":930.6999998092651,"fetchStart":930.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":930.6999998092651,"responseEnd":1120.4000005722046,"responseStart":1120.4000005722046,"secureConnectionStart":930.6999998092651}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":176,"responseStart":360,"responseEnd":374,"domLoading":363,"domInteractive":1074,"domContentLoadedEventStart":1074,"domContentLoadedEventEnd":1118,"domComplete":1789,"loadEventStart":1789,"loadEventEnd":1791,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1055.6000003814697},{"name":"bigPipe.sidebar-id.end","time":1056.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.start","time":1056.5},{"name":"bigPipe.activity-panel-pipe-id.end","time":1058.9000005722046},{"name":"activityTabFullyLoaded","time":1127.5}],"measures":[],"correlationId":"54fa9d24819d57","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":109,"dbReadsTimeInMs":16,"dbConnsTimeInMs":25,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}