Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-29180

Description of log_warnings incorrectly mentions "general log"

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Duplicate
    • 10.3.35, 10.4.25, 10.5.16, 10.6.8, 10.7.4, 10.8.3
    • N/A
    • Variables
    • None

    Description

      The description of log_warnings incorrectly mentions the "general log":

      static Sys_var_ulong Sys_log_warnings(
      		 
             "log_warnings",
      		 
             "Log some not critical warnings to the general log file."
      		 
             "Value can be between 0 and 11. Higher values mean more verbosity",
      		 
             SESSION_VAR(log_warnings),
      		 
             CMD_LINE(OPT_ARG, 'W'),
      		 
             VALID_RANGE(0, UINT_MAX), DEFAULT(2), BLOCK_SIZE(1));

      https://github.com/MariaDB/server/blob/mariadb-10.3.35/sql/sys_vars.cc#L1373

      The "general log" is most likely to refer to the "general query log", but this log is not affected by log_warnings. Instead, log_warnings affects the error log.

      The message should probably be edited to say something like this:

      Log some non-critical warnings to the error log. Meaningful values are between 0 and 11, where higher values mean more verbosity. Values between 11 and UNIT_MAX are equivalent to 11.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          sanja Oleksandr Byelkin added a comment - 

          commit 92938dcea2f06750aceb345b392899ff36395e6a (HEAD -> bb-10.4-MDEV-29180, origin/bb-10.4-MDEV-29180)
          		 
          Author: Oleksandr Byelkin <sanja@mariadb.com>
          		 
          Date:   Wed Sep 27 10:28:44 2023 +0200
          		 
           
          		 
              MDEV-29180: Description of log_warnings incorrectly mentions "general log"

          sanja Oleksandr Byelkin added a comment - commit 92938dcea2f06750aceb345b392899ff36395e6a (HEAD -> bb-10.4-MDEV-29180, origin/bb-10.4-MDEV-29180) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Wed Sep 27 10:28:44 2023 +0200   MDEV-29180: Description of log_warnings incorrectly mentions "general log"
          rucha174 Rucha Deodhar added a comment -

          looks ok. Thanks !

          rucha174 Rucha Deodhar added a comment - looks ok. Thanks !
          marko Marko Mäkelä added a comment -

          Apparently, this had been pushed already to 10.4?

          This failed to adjust the results of the tests sys_vars.sysvars_server_embedded and sys_vars.sysvars_server_notembedded on 32-bit systems, causing the tests to deterministically fail. Fixed.

          marko Marko Mäkelä added a comment - Apparently, this had been pushed already to 10.4? This failed to adjust the results of the tests sys_vars.sysvars_server_embedded and sys_vars.sysvars_server_notembedded on 32-bit systems, causing the tests to deterministically fail. Fixed .

          People

            sanja Oleksandr Byelkin
            GeoffMontee Geoff Montee (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.