[MDEV-29180] Description of log_warnings incorrectly mentions "general log" Created: 2022-07-27  Updated: 2023-11-28

Status: Stalled
Project: MariaDB Server
Component/s: Variables
Affects Version/s: 10.3.35, 10.4.25, 10.5.16, 10.6.8, 10.7.4, 10.8.3
Fix Version/s: 10.4, 10.5, 10.6

Type: Bug Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: Oleksandr Byelkin
Resolution: Unresolved Votes: 0
Labels: None


 Description   

The description of log_warnings incorrectly mentions the "general log":

static Sys_var_ulong Sys_log_warnings(
       "log_warnings",
       "Log some not critical warnings to the general log file."
       "Value can be between 0 and 11. Higher values mean more verbosity",
       SESSION_VAR(log_warnings),
       CMD_LINE(OPT_ARG, 'W'),
       VALID_RANGE(0, UINT_MAX), DEFAULT(2), BLOCK_SIZE(1));

https://github.com/MariaDB/server/blob/mariadb-10.3.35/sql/sys_vars.cc#L1373

The "general log" is most likely to refer to the "general query log", but this log is not affected by log_warnings. Instead, log_warnings affects the error log.

The message should probably be edited to say something like this:

Log some non-critical warnings to the error log. Meaningful values are between 0 and 11, where higher values mean more verbosity. Values between 11 and UNIT_MAX are equivalent to 11.



 Comments   
Comment by Oleksandr Byelkin [ 2023-09-27 ]

commit 92938dcea2f06750aceb345b392899ff36395e6a (HEAD -> bb-10.4-MDEV-29180, origin/bb-10.4-MDEV-29180)
Author: Oleksandr Byelkin <sanja@mariadb.com>
Date:   Wed Sep 27 10:28:44 2023 +0200
 
    MDEV-29180: Description of log_warnings incorrectly mentions "general log"

Comment by Rucha Deodhar [ 2023-09-28 ]

looks ok. Thanks !

Comment by Marko Mäkelä [ 2023-11-13 ]

Apparently, this had been pushed already to 10.4?

This failed to adjust the results of the tests sys_vars.sysvars_server_embedded and sys_vars.sysvars_server_notembedded on 32-bit systems, causing the tests to deterministically fail. Fixed.

Generated at Thu Feb 08 10:06:31 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.