[MDEV-29167] new db-level SHOW CREATE ROUTINE privilege - Jira

Nilnandan Joshi created issue - 2022-07-26 09:21

Sergei Golubchik made changes - 2022-09-01 12:54

Field	Original Value	New Value
Summary	SHOW CREATE ROUTINE should in included in ALL PRIVILEGES	new db-level SHOW CREATE ROUTINE privilege

Sergei Golubchik made changes - 2022-09-01 12:55

Description

ALL PRIVILEGES on the database level consists of:

SELECT, INSERT, UPDATE, DELETE, CREATE, DROP, GRANT, REFERENCES,
INDEX, ALTER, CREATE TMP, LOCK TABLES, EXECUTE, CREATE VIEW,
SHOW VIEW, CREATE PROC, ALTER PROC, EVENT, TRIGGER, DELETE HISTORY

It is requested to add SHOW CREATE ROUTINE in the ALL PRIVILEGES so we don't need to give separate permissions to view STORED PROCEDURE or FUNCTIONS of the database.

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Ralf Gebhardt made changes - 2022-11-04 13:10

Assignee

Oleksandr Byelkin [ sanja ]

Ralf Gebhardt made changes - 2022-11-04 13:10

Priority

Major [ 3 ]

Critical [ 2 ]

Ralf Gebhardt made changes - 2023-05-04 16:53

Fix Version/s

11.3 [ 28565 ]

Oleksandr Byelkin added a comment - 2023-08-28 08:46

ROUTINES == PROCEDURE or FUNCTION or PACKAGE ?
I think TRIGGER is not routine in this sens but part of the table, right?

Oleksandr Byelkin added a comment - 2023-08-28 08:46 ROUTINES == PROCEDURE or FUNCTION or PACKAGE ? I think TRIGGER is not routine in this sens but part of the table, right?

Oleksandr Byelkin made changes - 2023-08-29 09:53

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:

Oleksandr Byelkin made changes - 2023-08-29 09:55

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
SHOW_CREATE_ROUTINE_ACL inherited from compatibility from EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL, then SHOW ability determinated only by SHOW_CREATE_ROUTINE_ACL.

Oleksandr Byelkin made changes - 2023-08-29 10:25

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
SHOW_CREATE_ROUTINE_ACL inherited from compatibility from EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL, then SHOW ability determinated only by SHOW_CREATE_ROUTINE_ACL.

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
SHOW_CREATE_ROUTINE_ACL inherited from compatibility from EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL, then SHOW ability determinated only by SHOW_CREATE_ROUTINE_ACL.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

Oleksandr Byelkin made changes - 2023-08-31 06:27

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
SHOW_CREATE_ROUTINE_ACL inherited from compatibility from EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL, then SHOW ability determinated only by SHOW_CREATE_ROUTINE_ACL.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

Oleksandr Byelkin added a comment - 2023-09-04 12:14 - edited

commit 44e692d0dbc69e2658e6e0e017d750fc62c0e8b8 (HEAD -> bb-11.3-MDEV-29167, origin/bb-11.3-MDEV-29167)

Author: Oleksandr Byelkin <sanja@mariadb.com>

Date:   Mon Sep 4 13:04:06 2023 +0200

    MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Oleksandr Byelkin added a comment - 2023-09-04 12:14 - edited commit 44e692d0dbc69e2658e6e0e017d750fc62c0e8b8 (HEAD -> bb-11.3-MDEV-29167, origin/bb-11.3-MDEV-29167) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Sep 4 13:04:06 2023 +0200 MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Oleksandr Byelkin made changes - 2023-09-04 12:14

Status

Open [ 1 ]

In Progress [ 3 ]

Oleksandr Byelkin made changes - 2023-09-04 12:15

Assignee	Oleksandr Byelkin [ sanja ]	Sergei Golubchik [ serg ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Sergei Golubchik made changes - 2023-09-05 19:43

Assignee	Sergei Golubchik [ serg ]	Oleksandr Byelkin [ sanja ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Oleksandr Byelkin added a comment - 2023-09-06 07:55

commit 5c487eb813b50f4d7de55acb8229b192ce396e8b (HEAD -> bb-11.3-MDEV-29167)

Author: Oleksandr Byelkin <sanja@mariadb.com>

Date:   Wed Sep 6 09:54:42 2023 +0200

    Convert priveleges string representation definition to non-error-pron STRING_WITH_LEN

commit 1b986fc4a078a4da166a54161fc51605b5e2d52e

Author: Oleksandr Byelkin <sanja@mariadb.com>

Date:   Mon Sep 4 13:04:06 2023 +0200

    MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Oleksandr Byelkin added a comment - 2023-09-06 07:55 commit 5c487eb813b50f4d7de55acb8229b192ce396e8b (HEAD -> bb-11.3-MDEV-29167) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Wed Sep 6 09:54:42 2023 +0200 Convert priveleges string representation definition to non-error-pron STRING_WITH_LEN commit 1b986fc4a078a4da166a54161fc51605b5e2d52e Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Sep 4 13:04:06 2023 +0200 MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Oleksandr Byelkin made changes - 2023-09-06 07:56

Assignee	Oleksandr Byelkin [ sanja ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Oleksandr Byelkin added a comment - 2023-09-07 18:51

commit ecc135603805a36688b5ec55fe04fa2feee8e565 (HEAD -> bb-11.3-MDEV-29167, origin/bb-11.3-MDEV-29167)

Author: Oleksandr Byelkin <sanja@mariadb.com>

Date:   Mon Sep 4 13:04:06 2023 +0200

    MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Oleksandr Byelkin added a comment - 2023-09-07 18:51 commit ecc135603805a36688b5ec55fe04fa2feee8e565 (HEAD -> bb-11.3-MDEV-29167, origin/bb-11.3-MDEV-29167) Author: Oleksandr Byelkin <sanja@mariadb.com> Date: Mon Sep 4 13:04:06 2023 +0200 MDEV-29167 new db-level SHOW CREATE ROUTINE privilege

Sergei Golubchik added a comment - 2023-09-08 12:22

ecc1356038 is ok to push

Sergei Golubchik added a comment - 2023-09-08 12:22 ecc1356038 is ok to push

Sergei Golubchik made changes - 2023-09-08 12:22

Assignee	Sergei Golubchik [ serg ]	Oleksandr Byelkin [ sanja ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Sergei Golubchik made changes - 2023-09-12 19:53

Link

This issue is part of TODO-4253 [ TODO-4253 ]

Oleksandr Byelkin made changes - 2023-09-19 12:01

Status

Stalled [ 10000 ]

In Testing [ 10301 ]

Oleksandr Byelkin made changes - 2023-09-19 12:01

Assignee

Oleksandr Byelkin [ sanja ]

Alice Sherepa [ alice ]

Oleksandr Byelkin made changes - 2023-09-19 12:02

Assignee

Alice Sherepa [ alice ]

Oleksandr Byelkin [ sanja ]

Oleksandr Byelkin made changes - 2023-09-19 12:02

Assignee

Oleksandr Byelkin [ sanja ]

Lena Startseva [ JIRAUSER50478 ]

Ralf Gebhardt made changes - 2023-09-21 11:56

Labels

Preview_11.3

Lena Startseva added a comment - 2023-10-11 05:52

Testing done, ok to push

Lena Startseva added a comment - 2023-10-11 05:52 Testing done, ok to push

Lena Startseva made changes - 2023-10-11 05:52

Assignee	Lena Startseva [ JIRAUSER50478 ]	Oleksandr Byelkin [ sanja ]
Status	In Testing [ 10301 ]	Stalled [ 10000 ]

Oleksandr Byelkin made changes - 2023-10-18 06:03

issue.field.resolutiondate

2023-10-18 06:03:33.0

2023-10-18 06:03:33.396

Oleksandr Byelkin made changes - 2023-10-18 06:03

Fix Version/s		11.3.1 [ 29416 ]
Fix Version/s	11.3 [ 28565 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Michael Widenius made changes - 2023-10-29 12:56

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one has hte

Michael Widenius made changes - 2023-10-29 12:59

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one has hte

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one can give a user the 'show create routine' privilege, which allows the user to see the procedure text:
Example:
<<sql>>
grant show create routine on *.* to user@localhost;
show procedure

Michael Widenius made changes - 2023-10-29 13:00

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one can give a user the 'show create routine' privilege, which allows the user to see the procedure text:
Example:
<<sql>>
grant show create routine on *.* to user@localhost;
show procedure

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one can give a user the 'show create routine' privilege, which allows the user to see the procedure text:
Example:
<<sql>>
grant show create routine on *.* to user@localhost;
show procedure code test_db.sp;
<</sql>>

Michael Widenius made changes - 2023-10-29 13:01

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one can give a user the 'show create routine' privilege, which allows the user to see the procedure text:
Example:
<<sql>>
grant show create routine on *.* to user@localhost;
show procedure code test_db.sp;
<</sql>>

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one can give a user the 'show create routine' privilege, which allows the user to see the procedure text:
Example:
{noformat}
grant show create routine on *.* to user@localhost;
show procedure code test_db.sp;
{noformat}

Sergei Golubchik made changes - 2023-10-29 14:27

Description

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one can give a user the 'show create routine' privilege, which allows the user to see the procedure text:
Example:
{noformat}
grant show create routine on *.* to user@localhost;
show procedure code test_db.sp;
{noformat}

please, add a new db-level privilege SHOW CREATE ROUTINE so that the user with ALL PRIVILEGES on db level would be able to see all routines in that db

Update after discussing with Serg:
EXECUTE_ACL CREATE_PROC_ACL ALTER_PROC_ACL allow to get info about the routine, but SHOW_CREATE_ROUTINE_ACL should give the text.

This privilege related to PROCEDURE or FUNCTION or PACKAGE.

The effect of this MDEV is that one can give a user the 'show create routine' privilege, which allows the user to see the procedure text:
Example:
{code:sql}
grant show create routine on *.* to user@localhost;
show procedure code test_db.sp;
{code}

Ralf Gebhardt made changes - 2023-11-14 14:24

Link

This issue blocks MENT-1983 [ MENT-1983 ]

Sergei Golubchik made changes - 2024-02-28 19:27

Link

This issue causes ~~MDEV-33554~~ [ ~~MDEV-33554~~ ]

Ralf Gebhardt made changes - 2024-03-09 00:15

Link

This issue blocks MENT-1983 [ MENT-1983 ]

Jira Automation (IT) made changes - 2024-07-03 22:13

Zendesk Related Tickets

106381

Ralf Gebhardt made changes - 2024-10-03 07:42

Link

This issue relates to MENT-1983 [ MENT-1983 ]

MariaDB Server

new db-level SHOW CREATE ROUTINE privilege

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration