[MDEV-29068] Cascade foreign key updates do not apply in online alter - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: N/A
Fix Version/s: 11.2.1
Component/s: Data Definition - Alter Table
Labels:
None

Description

--source include/have_debug_sync.inc

--source include/have_innodb.inc

create table t1 (a int primary key) engine=InnoDB;

insert into t1 values (1),(2),(3);

create table t2 (b int, foreign key (b) references t1 (a) on update cascade) engine=InnoDB;

insert into t2 values (1),(2),(3);

--send

  set debug_sync= 'now wait_for downgraded';

--connect (con_alter,localhost,root,,test)

set debug_sync= 'alter_table_online_downgraded signal downgraded wait_for goforit';

--send

  alter table t2 add c int, algorithm=copy, lock=none;

--connection default

--reap

update t1 set a = 22 where a = 2;

set debug_sync= 'now signal goforit';

--connection con_alter

--reap

select * from t2;

# Cleanup

drop table t2, t1;

set debug_sync= reset;

bb-10.10-MDEV-16329 49ad87590
connection default;
update t1 set a = 22 where a = 2;
set debug_sync= 'now signal goforit';
connection con_alter;
select * from t2;
b c
1 NULL
2 NULL
3 NULL

Expected 22 instead of 2, via update cascade. 2 is now an orphan row.

Attachments

Issue Links

is caused by

MDEV-16329 Engine-independent online ALTER TABLE

Closed

relates to

MDEV-20640 [ERROR] InnoDB: tried to purge non-delete-marked record and Assertion `0' failed in row_purge_remove_sec_if_poss_leaf

Closed

MDEV-29182 Assertion `fld->field_no < table->n_v_def' failed on cascade FK update of table with vcol index in parent

Closed

MDEV-28808 Test MDEV-16329 (ALTER ONLINE TABLE) - Core server part

Closed

Activity

Ascending order - Click to sort in descending order

Elena Stepanova created issue - 2022-07-08 22:28

Elena Stepanova made changes - 2022-07-08 22:28

Field	Original Value	New Value
Link		This issue relates to ~~MDEV-16329~~ [ ~~MDEV-16329~~ ]

Nikita Malyavin made changes - 2022-07-15 15:30

Assignee

Sergei Golubchik [ serg ]

Nikita Malyavin [ nikitamalyavin ]

Nikita Malyavin made changes - 2022-07-19 17:26

Status

Open [ 1 ]

In Progress [ 3 ]

Nikita Malyavin made changes - 2022-07-21 23:14

Summary

Updates through foreign key cascade get lost when online alter is in progress

~~MDEV-29068~~ Cascade foreign key updates do not apply in online alter

Nikita Malyavin made changes - 2022-07-21 23:14

Summary

~~MDEV-29068~~ Cascade foreign key updates do not apply in online alter

Cascade foreign key updates do not apply in online alter

Nikita Malyavin made changes - 2022-07-21 23:41

Assignee	Nikita Malyavin [ nikitamalyavin ]	Marko Mäkelä [ marko ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Nikita Malyavin made changes - 2022-07-21 23:50

Link

This issue relates to ~~MDEV-19402~~ [ ~~MDEV-19402~~ ]

Marko Mäkelä made changes - 2022-07-25 13:35

Assignee	Marko Mäkelä [ marko ]	Nikita Malyavin [ nikitamalyavin ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Sergei Golubchik made changes - 2022-07-25 20:54

Fix Version/s		10.11 [ 27614 ]
Fix Version/s	10.10 [ 27530 ]

Nikita Malyavin made changes - 2022-07-26 13:41

Comment

[ {quote}
bq. Unlike THD, InnoDB always knew about the internals of TABLE and TABLE_SHARE. So, please do not add sql_get_maria_table_record().

Do you suggest to just include "table.h"?
{quote}

[~marko] I've checked, {{#include "table.h"}} appears only in ha_innobase.cc, so I think it's not a good idea.

I tried to move the function there before, but something has spoiled the impression, so I reverted. Maybe it was an apparent sql_is_online_alter_table call I couldn't move out of row0ins, but since I'm moving the check to ha_innobase::open, maybe it'll work, so I'll try again ]

Nikita Malyavin made changes - 2022-07-27 17:13

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Nikita Malyavin made changes - 2022-07-27 17:38

Link

This issue is blocked by MDEV-29181 [ MDEV-29181 ]

Nikita Malyavin made changes - 2022-07-27 17:43

Link

This issue relates to ~~MDEV-29182~~ [ ~~MDEV-29182~~ ]

Marko Mäkelä made changes - 2022-08-01 12:54

Link

This issue relates to ~~MDEV-20640~~ [ ~~MDEV-20640~~ ]

Nikita Malyavin made changes - 2022-08-22 21:46

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Nikita Malyavin made changes - 2022-08-26 08:58

Assignee	Nikita Malyavin [ nikitamalyavin ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Sergei Golubchik made changes - 2022-09-28 16:30

Link

This issue is caused by ~~MDEV-16329~~ [ ~~MDEV-16329~~ ]

Sergei Golubchik made changes - 2022-09-28 16:30

Link

This issue relates to ~~MDEV-16329~~ [ ~~MDEV-16329~~ ]

Nikita Malyavin made changes - 2022-10-21 10:26

Assignee

Sergei Golubchik [ serg ]

Nikita Malyavin [ nikitamalyavin ]

Nikita Malyavin made changes - 2022-10-21 10:26

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Nikita Malyavin made changes - 2022-10-31 13:00

Assignee	Nikita Malyavin [ nikitamalyavin ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Nikita Malyavin made changes - 2022-10-31 13:00

Fix Version/s		10.12 [ 28320 ]
Fix Version/s	10.11 [ 27614 ]

Ralf Gebhardt made changes - 2023-01-25 13:25

Fix Version/s		11.1 [ 28549 ]
Fix Version/s	11.0 [ 28320 ]

Sergei Golubchik made changes - 2023-02-16 20:02

Assignee	Sergei Golubchik [ serg ]	Nikita Malyavin [ nikitamalyavin ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Nikita Malyavin made changes - 2023-02-19 21:16

Status

Stalled [ 10000 ]

In Testing [ 10301 ]

Elena Stepanova made changes - 2023-04-02 16:38

Link

This issue relates to ~~MDEV-28808~~ [ ~~MDEV-28808~~ ]

Ralf Gebhardt made changes - 2023-05-30 08:18

Fix Version/s		11.2 [ 28603 ]
Fix Version/s	11.1 [ 28549 ]

Sergei Golubchik made changes - 2023-08-16 09:37

Fix Version/s		11.2.1 [ 29034 ]
Fix Version/s	11.2 [ 28603 ]
Resolution		Fixed [ 1 ]
Status	In Testing [ 10301 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2023-08-17 13:00

Link

This issue relates to ~~MDEV-19402~~ [ ~~MDEV-19402~~ ]

Sergei Golubchik made changes - 2023-11-05 18:21

Link

This issue is blocked by MDEV-29181 [ MDEV-29181 ]

People

Assignee:: Nikita Malyavin

Reporter:: Elena Stepanova

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2022-07-08 22:28

Updated:: 2024-06-22 15:24

Resolved:: 2023-08-16 09:37

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration