Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28827

Minor unsafe statement warning message improvement

Details

    Description

      2022-06-10 22:45:20 8 [Warning] Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. The statement is unsafe because it uses a LIMIT clause. This is unsafe because the set of rows included cannot be predicted Statement: UPDATE t1 SET c1=REPEAT('xyz',85), c2=REPEAT(c1, 100) ORDER by c1 LIMIT 2

      Please add a "." after "predicted" and before "Statement" ("predicted. Statement\:") to increase legibility for users.
      While doing the change also propose to change "since" to "as". Thanks

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          zhibozhang Zhibo Zhang added a comment -

          Hi Andrei, I will take over to deal with this issue if you do not mind!

          zhibozhang Zhibo Zhang added a comment - Hi Andrei, I will take over to deal with this issue if you do not mind!
          Elkin Andrei Elkin added a comment -

          zhibozhang, thanks for the heads up. But it'd make more sense to add up a single-liner to a first bug-fixes commit to 10.3 which we have - e.g MDEV-28530. I'd rather we do that.

          Elkin Andrei Elkin added a comment - zhibozhang , thanks for the heads up. But it'd make more sense to add up a single-liner to a first bug-fixes commit to 10.3 which we have - e.g MDEV-28530 . I'd rather we do that.
          Elkin Andrei Elkin added a comment -

          Roel, thanks for description suggestions. Still, considering not to change much in GA:s I picked only the punctuation part for them. I'll exchange with bnestere on the wording part that you pointed and then we'll decide
          how to handle 10.10 merge.

          Elkin Andrei Elkin added a comment - Roel , thanks for description suggestions. Still, considering not to change much in GA:s I picked only the punctuation part for them. I'll exchange with bnestere on the wording part that you pointed and then we'll decide how to handle 10.10 merge.
          Roel Roel Van de Paar added a comment -

          Thank you

          Roel Roel Van de Paar added a comment - Thank you

          People

            Elkin Andrei Elkin
            Roel Roel Van de Paar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.