[MDEV-28827] Minor unsafe statement warning message improvement Created: 2022-06-14  Updated: 2022-09-04  Resolved: 2022-09-03

Status: Closed
Project: MariaDB Server
Component/s: Binary Protocol
Affects Version/s: 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10
Fix Version/s: 10.3.37, 10.4.27, 10.5.18, 10.6.10, 10.7.6, 10.8.5, 10.9.3

Type: Bug Priority: Minor
Reporter: Roel Van de Paar Assignee: Andrei Elkin
Resolution: Fixed Votes: 0
Labels: beginner-friendly, warning


 Description    

2022-06-10 22:45:20 8 [Warning] Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. The statement is unsafe because it uses a LIMIT clause. This is unsafe because the set of rows included cannot be predicted Statement: UPDATE t1 SET c1=REPEAT('xyz',85), c2=REPEAT(c1, 100) ORDER by c1 LIMIT 2

Please add a "." after "predicted" and before "Statement" ("predicted. Statement\:") to increase legibility for users.
While doing the change also propose to change "since" to "as". Thanks

 Comments   
Comment by Zhibo Zhang [ 2022-08-25 ]

Hi Andrei, I will take over to deal with this issue if you do not mind!

Comment by Andrei Elkin [ 2022-08-26 ]

zhibozhang, thanks for the heads up. But it'd make more sense to add up a single-liner to a first bug-fixes commit to 10.3 which we have - e.g MDEV-28530. I'd rather we do that.

Comment by Andrei Elkin [ 2022-09-03 ]

Roel, thanks for description suggestions. Still, considering not to change much in GA:s I picked only the punctuation part for them. I'll exchange with bnestere on the wording part that you pointed and then we'll decide
how to handle 10.10 merge.

Comment by Roel Van de Paar [ 2022-09-04 ]

Thank you

Generated at Thu Feb 08 10:03:47 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.