Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28592

FreeBSD build does not include disk plugin

Details

    Description

      FreeBSD builds do not contain the disk.so plugin library in the plugins lib directory. If the plugin is being loaded by a .cnf config, this leads to 

      2022-05-15 20:40:18 0 [ERROR] mariadbd: Can't open shared library '/usr/local/lib/mysql/plugin/disks.so' (errno: 22, Cannot open "/usr/local/lib/mysql/plugin/disks.so")
      		 
      2022-05-15 20:40:18 0 [ERROR] Couldn't load plugins from 'disks.so'.

      on each startup

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          elenst Elena Stepanova added a comment -

          I guess that's why:

          10.3 3e564d468

          		 
          $ cat plugin/disks/CMakeLists.txt 
          IF("${CMAKE_SYSTEM}" MATCHES "Linux")
          		 
            INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/sql)
          		 
            MYSQL_ADD_PLUGIN(DISKS information_schema_disks.cc MODULE_ONLY RECOMPILE_FOR_EMBEDDED)
          		 
          ENDIF()

          elenst Elena Stepanova added a comment - I guess that's why: 10.3 3e564d468 $ cat plugin/disks/CMakeLists.txt IF("${CMAKE_SYSTEM}" MATCHES "Linux") INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/sql) MYSQL_ADD_PLUGIN(DISKS information_schema_disks.cc MODULE_ONLY RECOMPILE_FOR_EMBEDDED) ENDIF()
          serg Sergei Golubchik added a comment -

          FreeBSD doesn't have setmntent/getmntent that disks plugin uses. It would need an alternative BSD-specific implementation. likely based on getmntinfo().

          serg Sergei Golubchik added a comment - FreeBSD doesn't have setmntent/getmntent that disks plugin uses. It would need an alternative BSD-specific implementation. likely based on getmntinfo() .
          danblack Daniel Black added a comment -

          Also requires MDEV-27818 to be able to display zfs volumes.

          danblack Daniel Black added a comment - Also requires MDEV-27818 to be able to display zfs volumes.
          danblack Daniel Black added a comment -

          PR #2216

          Confirmed as building the plugin on FreeBSD. I can't see it run the test in mtr.

          danblack Daniel Black added a comment - PR #2216 Confirmed as building the plugin on FreeBSD . I can't see it run the test in mtr.
          serg Sergei Golubchik added a comment -

          review: https://github.com/MariaDB/server/pull/2216#issuecomment-1216828627

          serg Sergei Golubchik added a comment - review: https://github.com/MariaDB/server/pull/2216#issuecomment-1216828627

          People

            danblack Daniel Black
            hholzgra Hartmut Holzgraefe
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.