Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28465

Some calls to btr_pcur_close() are unnecessary

Details

    Description

      This came up while I was working on MDEV-13542. The function btr_pcur_close() is being invoked on local variables even when no cleanup needs to be done. Outside SPATIAL INDEX, the only needed cleanup might be freeing the buffer for old_rec, but only if btr_pcur_store_position() might have been invoked on the object. For spatial index, there is some r-tree path information that needs to be freed as well.

      Attachments

        Activity

          Transition Time In Source Status Execution Times
          Marko Mäkelä made transition -
          Open In Progress
          32m 34s 1
          Marko Mäkelä made transition -
          In Progress Closed
          19h 57m 1

          People

            marko Marko Mäkelä
            marko Marko Mäkelä
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.