[MDEV-28465] Some calls to btr_pcur_close() are unnecessary - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL)
Fix Version/s: 10.6.8, 10.7.4, 10.8.3, 10.9.1
Component/s: Storage Engine - InnoDB
Labels:
- performance

Description

This came up while I was working on ~~MDEV-13542~~. The function btr_pcur_close() is being invoked on local variables even when no cleanup needs to be done. Outside SPATIAL INDEX, the only needed cleanup might be freeing the buffer for old_rec, but only if btr_pcur_store_position() might have been invoked on the object. For spatial index, there is some r-tree path information that needs to be freed as well.

Attachments

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2022-05-03 14:18

Updated:: 2024-04-05 18:34

Resolved:: 2022-05-04 10:48

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.