Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28465

Some calls to btr_pcur_close() are unnecessary

Details

    Description

      This came up while I was working on MDEV-13542. The function btr_pcur_close() is being invoked on local variables even when no cleanup needs to be done. Outside SPATIAL INDEX, the only needed cleanup might be freeing the buffer for old_rec, but only if btr_pcur_store_position() might have been invoked on the object. For spatial index, there is some r-tree path information that needs to be freed as well.

      Attachments

        Activity

          marko Marko Mäkelä created issue -
          marko Marko Mäkelä made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          marko Marko Mäkelä made changes -
          issue.field.resolutiondate 2022-05-04 10:48:12.0 2022-05-04 10:48:12.145
          marko Marko Mäkelä made changes -
          Fix Version/s 10.6.8 [ 27506 ]
          Fix Version/s 10.7.4 [ 27504 ]
          Fix Version/s 10.8.3 [ 27502 ]
          Fix Version/s 10.9.1 [ 27114 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.7 [ 24805 ]
          Fix Version/s 10.8 [ 26121 ]
          Fix Version/s 10.9 [ 26905 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -
          rob.schwyzer@mariadb.com Rob Schwyzer (Inactive) made changes -

          People

            marko Marko Mäkelä
            marko Marko Mäkelä
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.