Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-28209

New mysql_upgrade message on minor-only upgrades is confusing

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Major
    • Resolution: Unresolved
    • 10.2.42, 10.3.33, 10.4.23, 10.6.6, 10.7.2, 10.5.15
    • 10.4, 10.5, 10.6
    • None
    • None

    Description

      Since MDEV-27279 mysql_upgrade only really runs when detecting major version upgrades, only checking the first two components of version numbers.

      There are two problems with this though.

      #1 this is not really mentioned in the release notes, they only have:

      {{* prohibition running two upgrades in parallel (MDEV-27068, MDEV-27107, MDEV-27279) }}

      All these MDEVs where handled by the same commit, but the commit was not exclusively about parallel upgrades. MDEV-27279 definitely was about something completely different

      #2 when running mysql_upgrade after a minor upgrade it now shows:

      This installation of MariaDB is already upgraded to 10.4.22-MariaDB.
      There is no need to run mysql_upgrade again for 10.4.24-MariaDB.
      You can use --force if you still want to run mysql_upgrade
      

      It is not clear from that message that the reason for this is that the major version did not change, just the minor (point) version. Not knowing about the MDEV-27579 change it rather looked as if something had gone wrong in the version string comparison logic.

      This message should definitely mention that it's caused by seeing the same major version, e.g.:

      This installation of MariaDB is already upgraded to major version 10.4 (10.4.22-MariaDB).
      There is no need to run mysql_upgrade again for 10.4.24-MariaDB as it is the same major version.
      You can use --force if you still want to run mysql_upgrade
      

      Attachments

        Issue Links

          Activity

            People

              monty Michael Widenius
              hholzgra Hartmut Holzgraefe
              Votes:
              4 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.