[MDEV-28209] New mysql_upgrade message on minor-only upgrades is confusing Created: 2022-04-01  Updated: 2023-04-27

Status: Open
Project: MariaDB Server
Component/s: None
Affects Version/s: 10.2.42, 10.3.33, 10.4.23, 10.6.6, 10.7.2, 10.5.15
Fix Version/s: 10.4, 10.5, 10.6

Type: Bug Priority: Major
Reporter: Hartmut Holzgraefe Assignee: Michael Widenius
Resolution: Unresolved Votes: 4
Labels: None

Issue Links:
Problem/Incident
is caused by MDEV-27279 mariadb_upgrade add --check-if-upgrad... Closed

 Description   

Since MDEV-27279 mysql_upgrade only really runs when detecting major version upgrades, only checking the first two components of version numbers.

There are two problems with this though.

#1 this is not really mentioned in the release notes, they only have:

{{* prohibition running two upgrades in parallel (MDEV-27068, MDEV-27107, MDEV-27279) }}

All these MDEVs where handled by the same commit, but the commit was not exclusively about parallel upgrades. MDEV-27279 definitely was about something completely different

#2 when running mysql_upgrade after a minor upgrade it now shows:

This installation of MariaDB is already upgraded to 10.4.22-MariaDB.
There is no need to run mysql_upgrade again for 10.4.24-MariaDB.
You can use --force if you still want to run mysql_upgrade

It is not clear from that message that the reason for this is that the major version did not change, just the minor (point) version. Not knowing about the MDEV-27579 change it rather looked as if something had gone wrong in the version string comparison logic.

This message should definitely mention that it's caused by seeing the same major version, e.g.:

This installation of MariaDB is already upgraded to major version 10.4 (10.4.22-MariaDB).
There is no need to run mysql_upgrade again for 10.4.24-MariaDB as it is the same major version.
You can use --force if you still want to run mysql_upgrade



 Comments   
Comment by Hartmut Holzgraefe [ 2022-04-01 ]

Knowledge base was also not change to reflect the MDEV-27279 change, it still says to run mysql_upgrade on minor upgrades on

https://mariadb.com/kb/en/upgrading-between-minor-versions-on-linux/

Generated at Thu Feb 08 09:58:56 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.