[MDEV-28106] S3 tries to include thread.h while compiling on Windows - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Blocker
Resolution: Fixed
Affects Version/s: 10.5(EOL), 10.6, 10.7(EOL), 10.8(EOL)
Fix Version/s: 10.7.4, 10.5.16, 10.6.8
Component/s: Compiling, Storage Engine - S3
Labels:
None

Description

Usually S3 doesn't even try to build on Windows, because it wants CURL and it's almost never there. If, however, it does find CURL, it tries to build, but eventually fails with

  C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083:  Cannot open include file: 'pthread.h': No such file or directory [C:\_home\10.6x\storage\maria\s3.vcxproj]

C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083: #include <pthread.h> [C:\_home\10.6x\storage\maria\s3.vcxproj]

C:\_home\10.6x\storage\maria\libmarias3\src\marias3.c(23,10): error C1083:          ^ [C:\_home\10.6x\storage\maria\s3.vcxproj]

I'm guessing it is missing ifdef or something – that is, if we want to build it on Windows at all, otherwise it should get skipped earlier.

Attachments

Issue Links

relates to

MDEV-28107 S3 doesn't build if CURL is in non-default location

Closed

MDEV-28104 Typo in storage/maria/s3_func.c: 'FN_DECVHAR'

Closed

Activity

People

Assignee:: Sergei Golubchik

Reporter:: Elena Stepanova

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2022-03-16 23:27

Updated:: 2022-03-23 17:51

Resolved:: 2022-03-23 17:51

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 10m

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.