Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27684

Spider: remove pattern str->reserve() then str->q_append()

    XMLWordPrintable

Details

    Description

      Remove the following pattern that can be seen anywhere in the Spider codebase. 

      if (str->reserve(SPIDER_SQL_WHERE_LEN))
      		 
        DBUG_RETURN(HA_ERR_OUT_OF_MEM);
      		 
      str->q_append(SPIDER_SQL_WHERE_STR, SPIDER_SQL_WHERE_LEN);

      This makes the code less readable and is error-prone (e.g., MDEV-27184).

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27184 Assertion `(old_top == initial_top (av) && old_size == 0) || ((unsigned long) (old_size) >= MINSIZE && prev_inuse (old_top) && ((unsigned long) old_end & (pagesize - 1)) == 0)' failed, Assertion `str.alloced_length() >= str.length() + data_len' failed

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-26384 Spider: add new query building helper function

          • Major - Major loss of function.
          • Closed

          Activity

            People

              ycp Yuchen Pei
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.