Type:
Priority:
Resolution:
Done
Affects Version/s:
None
relates to
MDEV-33728
remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION in spider
Closed
made changes -
2022-01-27 17:03
Assignee
Nayuta Yanagisawa
[ JIRAUSER47117
]
Alexey Botchkov
[ holyfoot
]
Status
Stalled
[ 10000
]
In Review
[ 10002
]
made changes -
2022-01-27 19:09
Summary
Spider: remove dead code in #if MYSQL_VERSION_ID ...
Spider: remove #if MYSQL_VERSION_ID > ${VERSION}
made changes -
2022-01-28 06:50
Summary
Spider: remove #if MYSQL_VERSION_ID > ${VERSION}
Spider: remove #if MYSQL_VERSION_ID < ${VERSION}
made changes -
2022-01-28 07:41
Assignee
Nayuta Yanagisawa
[ JIRAUSER47117
]
Alexey Botchkov
[ holyfoot
]
Status
Stalled
[ 10000
]
In Review
[ 10002
]
made changes -
2022-02-09 09:00
Assignee
Alexey Botchkov
[ holyfoot
]
Nayuta Yanagisawa
[ JIRAUSER47117
]
Status
In Review
[ 10002
]
Stalled
[ 10000
]
made changes -
2022-02-10 06:31
Fix Version/s
10.9.0
[ 27113
]
Fix Version/s
10.9
[ 26905
]
Resolution
Done
[ 10200
]
Status
Stalled
[ 10000
]
Closed
[ 6
]
{"report":{"fcp":1262,"ttfb":325.5,"pageVisibility":"visible","entityId":107332,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"a523528c-8c3a-4173-88de-9ba34633bd05","navigationType":0,"readyForUser":1327.6000000238419,"redirectCount":0,"resourceLoadedEnd":1734.2000000476837,"resourceLoadedStart":335.60000002384186,"resourceTiming":[{"duration":453.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":335.60000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":335.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":789.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":453.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":335.89999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":335.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":789.5,"responseStart":0,"secureConnectionStart":0},{"duration":462.1999999284744,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":336.10000002384186,"connectEnd":336.10000002384186,"connectStart":336.10000002384186,"domainLookupEnd":336.10000002384186,"domainLookupStart":336.10000002384186,"fetchStart":336.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":336.10000002384186,"responseEnd":798.2999999523163,"responseStart":798.2999999523163,"secureConnectionStart":336.10000002384186},{"duration":500.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":336.7000000476837,"connectEnd":336.7000000476837,"connectStart":336.7000000476837,"domainLookupEnd":336.7000000476837,"domainLookupStart":336.7000000476837,"fetchStart":336.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":336.7000000476837,"responseEnd":837.2999999523163,"responseStart":837.2999999523163,"secureConnectionStart":336.7000000476837},{"duration":504,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":336.89999997615814,"connectEnd":336.89999997615814,"connectStart":336.89999997615814,"domainLookupEnd":336.89999997615814,"domainLookupStart":336.89999997615814,"fetchStart":336.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":336.89999997615814,"responseEnd":840.8999999761581,"responseStart":840.8999999761581,"secureConnectionStart":336.89999997615814},{"duration":504.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":337,"connectEnd":337,"connectStart":337,"domainLookupEnd":337,"domainLookupStart":337,"fetchStart":337,"redirectEnd":0,"redirectStart":0,"requestStart":337,"responseEnd":841.2999999523163,"responseStart":841.2999999523163,"secureConnectionStart":337},{"duration":504.39999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":337.2000000476837,"connectEnd":337.2000000476837,"connectStart":337.2000000476837,"domainLookupEnd":337.2000000476837,"domainLookupStart":337.2000000476837,"fetchStart":337.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":337.2000000476837,"responseEnd":841.6000000238419,"responseStart":841.6000000238419,"secureConnectionStart":337.2000000476837},{"duration":601.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":337.39999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":337.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":938.8999999761581,"responseStart":0,"secureConnectionStart":0},{"duration":504.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":337.5,"connectEnd":337.5,"connectStart":337.5,"domainLookupEnd":337.5,"domainLookupStart":337.5,"fetchStart":337.5,"redirectEnd":0,"redirectStart":0,"requestStart":337.5,"responseEnd":842.1000000238419,"responseStart":842.1000000238419,"secureConnectionStart":337.5},{"duration":601.3999999761581,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":337.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":337.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":939.1000000238419,"responseStart":0,"secureConnectionStart":0},{"duration":504.8000000715256,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":337.7999999523163,"connectEnd":337.7999999523163,"connectStart":337.7999999523163,"domainLookupEnd":337.7999999523163,"domainLookupStart":337.7999999523163,"fetchStart":337.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":337.7999999523163,"responseEnd":842.6000000238419,"responseStart":842.6000000238419,"secureConnectionStart":337.7999999523163},{"duration":757.3999999761581,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":346,"connectEnd":346,"connectStart":346,"domainLookupEnd":346,"domainLookupStart":346,"fetchStart":346,"redirectEnd":0,"redirectStart":0,"requestStart":346,"responseEnd":1103.3999999761581,"responseStart":1103.3999999761581,"secureConnectionStart":346},{"duration":1381.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":351.60000002384186,"connectEnd":351.60000002384186,"connectStart":351.60000002384186,"domainLookupEnd":351.60000002384186,"domainLookupStart":351.60000002384186,"fetchStart":351.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":351.60000002384186,"responseEnd":1733.3999999761581,"responseStart":1733.2999999523163,"secureConnectionStart":351.60000002384186},{"duration":184.60000002384186,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":950,"connectEnd":950,"connectStart":950,"domainLookupEnd":950,"domainLookupStart":950,"fetchStart":950,"redirectEnd":0,"redirectStart":0,"requestStart":950,"responseEnd":1134.6000000238419,"responseStart":1134.6000000238419,"secureConnectionStart":950},{"duration":530.7000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1203.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1203.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1734.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":579.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1204.5,"connectEnd":1204.5,"connectStart":1204.5,"domainLookupEnd":1204.5,"domainLookupStart":1204.5,"fetchStart":1204.5,"redirectEnd":0,"redirectStart":0,"requestStart":1204.5,"responseEnd":1784.2000000476837,"responseStart":1784.2000000476837,"secureConnectionStart":1204.5},{"duration":586.1000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":1204.7999999523163,"connectEnd":1204.7999999523163,"connectStart":1204.7999999523163,"domainLookupEnd":1204.7999999523163,"domainLookupStart":1204.7999999523163,"fetchStart":1204.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":1204.7999999523163,"responseEnd":1790.8999999761581,"responseStart":1790.8999999761581,"secureConnectionStart":1204.7999999523163}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":130,"responseStart":326,"responseEnd":353,"domLoading":329,"domInteractive":1765,"domContentLoadedEventStart":1765,"domContentLoadedEventEnd":1807,"domComplete":2323,"loadEventStart":2323,"loadEventEnd":2323,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1735.2000000476837},{"name":"bigPipe.sidebar-id.end","time":1736.1000000238419},{"name":"bigPipe.activity-panel-pipe-id.start","time":1736.2000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":1740.2999999523163},{"name":"activityTabFullyLoaded","time":1821.3999999761581}],"measures":[],"correlationId":"c8ed97d7e9a34a","effectiveType":"4g","downlink":9.6,"rtt":0,"serverDuration":132,"dbReadsTimeInMs":26,"dbConnsTimeInMs":35,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Technical task
Major
MDEV-33728 remove use of MYSQL_VERSION_ID and MARIADB_BASE_VERSION in spider
I did this by my hand. I left the indentation as is to reduce the possibility of error. https://github.com/MariaDB/server/commit/e3537be73d5eb20d5d029b622142c3afe01e7ab3