Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27314

Buffer pool resize output: 14 minor typo/capitalization/uniformity/wording updates

    XMLWordPrintable

    Details

      Description

      Some minor typo/capitalization/uniformity updates:

      10.8.0 23849209738153bed4ea60f39830305840ee4025 (Optimized)

      2021-12-20  6:46:11 8 [Note] InnoDB: Requested to resize buffer pool. (new size: 9830400 bytes)
      2021-12-20  6:46:11 0 [Note] InnoDB: Resizing buffer pool from 300.000MiB to 9.375MiB (unit=4.688MiB).
      2021-12-20  6:46:11 0 [Note] InnoDB: Disabling adaptive hash index.
      2021-12-20  6:46:11 0 [Note] InnoDB: Withdrawing blocks to be shrunken.
      2021-12-20  6:46:11 0 [Note] InnoDB: start to withdraw the last 18408 blocks
      2021-12-20  6:46:11 0 [Note] InnoDB: withdrawing blocks. (18408/18408)
      2021-12-20  6:46:11 0 [Note] InnoDB: withdrew 18285 blocks from free list. Tried to relocate 123 pages (18408/18408)
      2021-12-20  6:46:11 0 [Note] InnoDB: withdrawn target: 18408 blocks
      2021-12-20  6:46:11 0 [Note] InnoDB: Latching whole of buffer pool.
      2021-12-20  6:46:11 0 [Note] InnoDB: buffer pool resizing with chunks 64 to 2.
      2021-12-20  6:46:11 0 [Note] InnoDB: 62 chunks (18408 blocks) were freed.
      2021-12-20  6:46:11 0 [Note] InnoDB: Resizing also other hash tables.
      2021-12-20  6:46:11 0 [Note] InnoDB: Resized hash tables at lock_sys, adaptive hash index, dictionary.
      2021-12-20  6:46:11 0 [Note] InnoDB: Completed to resize buffer pool from 314572800 to 9830400.
      2021-12-20  6:46:11 0 [Note] InnoDB: Completed resizing buffer pool at 211220  6:46:11.
      

      Proposed updates:

      1. "InnoDB: Buffer pool resize requested (New size: 9830400 bytes)." - improved wording, or, if possible "InnoDB: Buffer pool resize requested by client xyz (New size: 9830400 bytes).". Also added "N" uppercase, and moved final dot to end only to correspond with the next "...(unit..." line.
      2. "(unit = 4.688MiB).". Spaces added to align with formatting used in MDEV-27158.
      3. "InnoDB: Start to withdraw the last 18408 blocks." - uppercase "S" and "."
      4. "InnoDB: Withdrawing blocks. (18408/18408)." - uppercase "W" and "."
      5. "InnoDB: Withdrew 18285 blocks from free list. Tried to relocate 123 block (18408/18408)." - uppercase "W", "." and "blocks" instead of "pages" to make it uniform.
      6. "InnoDB: Withdrawn target: 18408 blocks." - uppercase "W" and "."
      7. "InnoDB: Latching entire buffer pool." - improved wording
      8. "InnoDB: Resizing buffer pool from 64 to 2 chunks.' - improved wording, check wording for correctness?
      9. "InnoDB: 62 Chunks (18408 blocks) were freed." - uppercase "C"
      10. "InnoDB: Resizing other hash tables." or "InnoDB: Additionally resizing other hash tables." - improved wording, first one preferred, or even better: "InnoDB: Resizing other hash tables: lock_sys, adaptive hash index, and dictionary."
      11. "InnoDB: Resized hash tables: lock_sys, adaptive hash index, and dictionary." - improved wording
      12. 'InnoDB: Completed resizing buffer pool from 314572800 to 9830400 bytes." - improved wording, "bytes"
      13. "InnoDB: Completed resizing buffer pool on 21/12/20 at 6:46:11.". Removed double space, change date formatting.
      14. Potentially the "withdrawing blocks" messages can be reduced by one line.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              danblack Daniel Black
              Reporter:
              Roel Roel Van de Paar
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.