[MDEV-27314] Buffer pool resize output: 14 minor typo/capitalization/uniformity/wording updates Created: 2021-12-20  Updated: 2022-05-27  Resolved: 2022-05-24

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Affects Version/s: 10.8
Fix Version/s: 10.8.1

Type: Bug Priority: Minor
Reporter: Roel Van de Paar Assignee: Daniel Black
Resolution: Fixed Votes: 0
Labels: beginner-friendly

Issue Links:
Relates
relates to MDEV-27158 Humanize the number of bytes in InnoD... Closed

 Description   

Some minor typo/capitalization/uniformity updates:

10.8.0 23849209738153bed4ea60f39830305840ee4025 (Optimized)

 
2021-12-20  6:46:11 8 [Note] InnoDB: Requested to resize buffer pool. (new size: 9830400 bytes)
 
2021-12-20  6:46:11 0 [Note] InnoDB: Resizing buffer pool from 300.000MiB to 9.375MiB (unit=4.688MiB).
 
2021-12-20  6:46:11 0 [Note] InnoDB: Disabling adaptive hash index.
 
2021-12-20  6:46:11 0 [Note] InnoDB: Withdrawing blocks to be shrunken.
 
2021-12-20  6:46:11 0 [Note] InnoDB: start to withdraw the last 18408 blocks
 
2021-12-20  6:46:11 0 [Note] InnoDB: withdrawing blocks. (18408/18408)
 
2021-12-20  6:46:11 0 [Note] InnoDB: withdrew 18285 blocks from free list. Tried to relocate 123 pages (18408/18408)
 
2021-12-20  6:46:11 0 [Note] InnoDB: withdrawn target: 18408 blocks
 
2021-12-20  6:46:11 0 [Note] InnoDB: Latching whole of buffer pool.
 
2021-12-20  6:46:11 0 [Note] InnoDB: buffer pool resizing with chunks 64 to 2.
 
2021-12-20  6:46:11 0 [Note] InnoDB: 62 chunks (18408 blocks) were freed.
 
2021-12-20  6:46:11 0 [Note] InnoDB: Resizing also other hash tables.
 
2021-12-20  6:46:11 0 [Note] InnoDB: Resized hash tables at lock_sys, adaptive hash index, dictionary.
 
2021-12-20  6:46:11 0 [Note] InnoDB: Completed to resize buffer pool from 314572800 to 9830400.
 
2021-12-20  6:46:11 0 [Note] InnoDB: Completed resizing buffer pool at 211220  6:46:11.

Proposed updates:

  1. "InnoDB: Buffer pool resize requested (New size: 9830400 bytes)." - improved wording, or, if possible "InnoDB: Buffer pool resize requested by client xyz (New size: 9830400 bytes).". Also added "N" uppercase, and moved final dot to end only to correspond with the next "...(unit..." line.
  2. "(unit = 4.688MiB).". Spaces added to align with formatting used in MDEV-27158.
  3. "InnoDB: Start to withdraw the last 18408 blocks." - uppercase "S" and "."
  4. "InnoDB: Withdrawing blocks. (18408/18408)." - uppercase "W" and "."
  5. "InnoDB: Withdrew 18285 blocks from free list. Tried to relocate 123 block (18408/18408)." - uppercase "W", "." and "blocks" instead of "pages" to make it uniform.
  6. "InnoDB: Withdrawn target: 18408 blocks." - uppercase "W" and "."
  7. "InnoDB: Latching entire buffer pool." - improved wording
  8. "InnoDB: Resizing buffer pool from 64 to 2 chunks.' - improved wording, check wording for correctness?
  9. "InnoDB: 62 Chunks (18408 blocks) were freed." - uppercase "C"
  10. "InnoDB: Resizing other hash tables." or "InnoDB: Additionally resizing other hash tables." - improved wording, first one preferred, or even better: "InnoDB: Resizing other hash tables: lock_sys, adaptive hash index, and dictionary."
  11. "InnoDB: Resized hash tables: lock_sys, adaptive hash index, and dictionary." - improved wording
  12. 'InnoDB: Completed resizing buffer pool from 314572800 to 9830400 bytes." - improved wording, "bytes"
  13. "InnoDB: Completed resizing buffer pool on 21/12/20 at 6:46:11.". Removed double space, change date formatting.
  14. Potentially the "withdrawing blocks" messages can be reduced by one line.

 Comments   
Comment by Marko Mäkelä [ 2021-12-20 ]

I think that this belongs to the author of MDEV-27158.

Comment by Daniel Black [ 2022-01-24 ]

Fixed thanks to contributor haidong.

Point 13 no longer includes the appended timestamp which looks like a good improvement to me.

Comment by Roel Van de Paar [ 2022-01-26 ]

+1 on all points in danblack's last comment. Thank you haidong

Comment by Haidong Ji [ 2022-01-27 ]

No problem, you are welcome, Roel

Comment by Roel Van de Paar [ 2022-05-07 ]

danblack Maybe we could condense this to one message?

2022-05-07 17:10:33 0 [Note] InnoDB: Completed resizing buffer pool from 14745600 to 19660800 bytes.
 
2022-05-07 17:10:33 0 [Note] InnoDB: Completed resizing buffer pool.
 
2022-05-07 17:10:33 8 [Note] InnoDB: Completed resizing buffer pool. (New size: 19660800 bytes).

Comment by Haidong Ji [ 2022-05-09 ]

I can take this.

Since this Jira issue is closed, should we create a new one to track it?

Comment by Daniel Black [ 2022-05-09 ]

keep the same mdev on something so largely trivial.

Comment by Roel Van de Paar [ 2022-05-09 ]

haidong danblack Thank you. I've reopened this ticket for the additional modification.

Comment by Sergei Golubchik [ 2022-05-24 ]

closed again. it's very confusing to keep an issue open if the fix was already pushed and released.
we could tolerate that for a short while for trivial (indeed) issues. But it was two weeks already. So I'm closing it back.

Comment by Haidong Ji [ 2022-05-24 ]

Sorry it took a while, @Sergei Golubchik. I'm switching jobs and have been busy.

I think the code is done now. If no additional feedback, it will hopefully close this for good

Comment by Daniel Black [ 2022-05-26 ]

Done. Second improvement from haidong done in 10.8.4.

Generated at Thu Feb 08 09:51:59 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.