Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27158

Humanize the number of bytes in InnoDB messages

Details

    Description

      For axel for https://github.com/MariaDB/server/pull/1956#issuecomment-984543127

      While we are at it: can we have some diagnostics on buffer pool allocation please? And also use some more meaningful units for the different sizes. Instead of this:

      [Note] InnoDB: Initializing buffer pool, total size = 17179869184, chunk size = 134217728                         
      [Note] InnoDB: Completed initialization of buffer pool

      I would like to see:

      [Note] InnoDB: Initializing buffer pool, total size = 16384MB, chunk size = 128MB
      		 
      [Note] InnoDB: Allocating buffer pool with page size = 2048KB
      		 
      [Note] InnoDB: Completed initialization of buffer pool

      Buffer pool size and chunk size could use MB and fall back to KB in case they are very small. Page size can be given in KB.

      Attachments

        Issue Links

          relates to

          New Feature - A new feature of the product, which has yet to be developed. MDEV-25652 Add support for SI suffixes in SET statement for configuring size-related variables

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27314 Buffer pool resize output: 14 minor typo/capitalization/uniformity/wording updates

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31628 InnoDB reports the wrong system tablespace size on bootstrap

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35498 InnoDB logger class causes significant code bloat

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä added a comment -

            Please see my comment in MDEV-25652. I don’t think that we should abuse decimal multiplier names like k, M, G, T (10³, 10⁶, 10⁹, 10¹²) for binary ones (2¹⁰, 2²⁰, 2³⁰, 2⁴⁰). RAM is usually measured in powers of 1024 (2¹⁰) octets or bits. We should use units like KiB, MiB, GiB, TiB.

            marko Marko Mäkelä added a comment - Please see my comment in MDEV-25652 . I don’t think that we should abuse decimal multiplier names like k, M, G, T (10³, 10⁶, 10⁹, 10¹²) for binary ones (2¹⁰, 2²⁰, 2³⁰, 2⁴⁰). RAM is usually measured in powers of 1024 (2¹⁰) octets or bits. We should use units like KiB, MiB, GiB, TiB .
            danblack Daniel Black added a comment -

            Yep: https://github.com/MariaDB/server/pull/1957/files#diff-fb4e25d0ee1a9ec85c94db6bd754c69977d7a23cf3bea4a1723ef3741c96e6a8R321-R322

            danblack Daniel Black added a comment - Yep: https://github.com/MariaDB/server/pull/1957/files#diff-fb4e25d0ee1a9ec85c94db6bd754c69977d7a23cf3bea4a1723ef3741c96e6a8R321-R322
            Roel Roel Van de Paar added a comment -

            This seems only partially implemented (page size missing)?

            10.8.0 preview-10.8-MDEV-14425-innodb 23849209738153bed4ea60f39830305840ee4025 (Debug)

            		 
            2021-12-20  5:18:54 0 [Note] InnoDB: Initializing buffer pool, total size = 128.000MiB, chunk size = 2.000MiB
            		 
            2021-12-20  5:18:54 0 [Note] InnoDB: Completed initialization of buffer pool

            Roel Roel Van de Paar added a comment - This seems only partially implemented (page size missing)? 10.8.0 preview-10.8-MDEV-14425-innodb 23849209738153bed4ea60f39830305840ee4025 (Debug) 2021-12-20 5:18:54 0 [Note] InnoDB: Initializing buffer pool, total size = 128.000MiB, chunk size = 2.000MiB 2021-12-20 5:18:54 0 [Note] InnoDB: Completed initialization of buffer pool
            Roel Roel Van de Paar added a comment - - edited

            danblack Could you please add an MTR test that does a buffer pool resize and also check the output of the same, i.e. potentially that output may be updated as well? Vice versa, we could also add unit size here to align with buffer pool resize output?) Ref MDEV-27314

            Roel Roel Van de Paar added a comment - - edited danblack Could you please add an MTR test that does a buffer pool resize and also check the output of the same, i.e. potentially that output may be updated as well? Vice versa, we could also add unit size here to align with buffer pool resize output?) Ref MDEV-27314
            mleich Matthias Leich added a comment - 

            The tree
            		 
            origin/bb-10.8-MDEV-14425 614e46b89ffe7357e5b72ea0d0fd3f490567a384 2022-01-13T20:32:56+02:00
            		 
            contains the modifications made by MDEV-27158 and behaved well in RQG testing.
            		 
            Bad effects observed exist in the main trees too or are known and caused by other MDEVs.
            		 
            Please note that the RQG tests do not check if the MDEV-27158 specification is followed.

            mleich Matthias Leich added a comment - The tree origin/bb-10.8-MDEV-14425 614e46b89ffe7357e5b72ea0d0fd3f490567a384 2022-01-13T20:32:56+02:00 contains the modifications made by MDEV-27158 and behaved well in RQG testing. Bad effects observed exist in the main trees too or are known and caused by other MDEVs. Please note that the RQG tests do not check if the MDEV-27158 specification is followed.

            People

              danblack Daniel Black
              danblack Daniel Black
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.