[MDEV-27158] Humanize the number of bytes in InnoDB messages Created: 2021-12-03  Updated: 2023-07-05  Resolved: 2022-01-18

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Fix Version/s: 10.8.1

Type: Task Priority: Minor
Reporter: Daniel Black Assignee: Daniel Black
Resolution: Fixed Votes: 1
Labels: None

Issue Links:
Relates
relates to MDEV-25652 Add support for SI suffixes in SET st... Open
relates to MDEV-27314 Buffer pool resize output: 14 minor t... Closed
relates to MDEV-31628 InnoDB reports the wrong system table... Closed

 Description   

For axel for https://github.com/MariaDB/server/pull/1956#issuecomment-984543127

While we are at it: can we have some diagnostics on buffer pool allocation please? And also use some more meaningful units for the different sizes. Instead of this:

[Note] InnoDB: Initializing buffer pool, total size = 17179869184, chunk size = 134217728                         
[Note] InnoDB: Completed initialization of buffer pool

I would like to see:

[Note] InnoDB: Initializing buffer pool, total size = 16384MB, chunk size = 128MB
[Note] InnoDB: Allocating buffer pool with page size = 2048KB
[Note] InnoDB: Completed initialization of buffer pool

Buffer pool size and chunk size could use MB and fall back to KB in case they are very small. Page size can be given in KB.



 Comments   
Comment by Marko Mäkelä [ 2021-12-03 ]

Please see my comment in MDEV-25652. I don’t think that we should abuse decimal multiplier names like k, M, G, T (10³, 10⁶, 10⁹, 10¹²) for binary ones (2¹⁰, 2²⁰, 2³⁰, 2⁴⁰). RAM is usually measured in powers of 1024 (2¹⁰) octets or bits. We should use units like KiB, MiB, GiB, TiB.

Comment by Daniel Black [ 2021-12-03 ]

Yep: https://github.com/MariaDB/server/pull/1957/files#diff-fb4e25d0ee1a9ec85c94db6bd754c69977d7a23cf3bea4a1723ef3741c96e6a8R321-R322

Comment by Roel Van de Paar [ 2021-12-19 ]

This seems only partially implemented (page size missing)?

10.8.0 preview-10.8-MDEV-14425-innodb 23849209738153bed4ea60f39830305840ee4025 (Debug)

2021-12-20  5:18:54 0 [Note] InnoDB: Initializing buffer pool, total size = 128.000MiB, chunk size = 2.000MiB
2021-12-20  5:18:54 0 [Note] InnoDB: Completed initialization of buffer pool

Comment by Roel Van de Paar [ 2021-12-20 ]

danblack Could you please add an MTR test that does a buffer pool resize and also check the output of the same, i.e. potentially that output may be updated as well? Vice versa, we could also add unit size here to align with buffer pool resize output?) Ref MDEV-27314

Comment by Matthias Leich [ 2022-01-14 ]

The tree
origin/bb-10.8-MDEV-14425 614e46b89ffe7357e5b72ea0d0fd3f490567a384 2022-01-13T20:32:56+02:00
contains the modifications made by MDEV-27158 and behaved well in RQG testing.
Bad effects observed exist in the main trees too or are known and caused by other MDEVs.
Please note that the RQG tests do not check if the MDEV-27158 specification is followed. 

Generated at Thu Feb 08 09:50:47 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.