Details
-
Bug
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Duplicate
-
10.3(EOL), 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.11
Description
The loading of the spider plugin causes a background thread to be created and the set of sql in storage/spider/spd_init_query.h to be run.
Running mysql_upgrade at the same time the initialization of spider is occurring can cause problems as MDEV-27068 shows.
One of the conflicts was
- ALTER TABLE proc MODIFY
- and spiders' {{ drop procedure}}
Other similar conflicts can occur on plugin and udf function installation
MDEV-19275 sql service for plugins means 10.7+ can simply this. Is it valid during initialization? Not 100% sure, but if it is, it would avoid the mariadb-upgrade conflicts.
Other simplifications are:
spider_fix_one_table looks like a simple modification of the ALTER TABLE syntax to use the column IF NOT EXISTS syntax of https://mariadb.com/kb/en/alter-table/ would negate the need for this function.
mysql.spider_fix_system_tables, a procedure with zero arguments that sets user variables could be inline. Or better, removed and use the executable comment syntax in https://mariadb.com/kb/en/comment-syntax/#executable-comment-syntax to run statements based on the server version.
Can the following be implemented another way install plugin [spider_rewrite soname 'ha_spider' (INSTALL PLUGIN has IF NOT EXISTS from 10.4)
Can the udf functions created another way?
Is there are reason (all of) this couldn't be part of mysql-upgrade? wrapped under conditional upgrade if spider is installed?
Attachments
Issue Links
- is blocked by
-
MDEV-27107
prevent two mariadb-upgrade running in parallel
-
- Closed
-
- is part of
-
-
- Closed
-
- relates to
-
-
- Closed
-
-
MDEV-27998
Delete spider_table_crd_thread_count and spider_table_sts_thread_count
-
- Stalled
-
-
MDEV-28553 Spider: clean up plugin initialization SQLs in spd_init_query.h
-
- Open
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Stalled
-
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Link |
This issue relates to |
| Assignee | Nayuta Yanagisawa [ JIRAUSER47117 ] |
| Workflow | MariaDB v3 [ 127863 ] | MariaDB v4 [ 143372 ] |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue relates to |
| Link |
This issue is blocked by |
| Affects Version/s | 10.3 [ 22126 ] | |
| Affects Version/s | 10.4 [ 22408 ] | |
| Affects Version/s | 10.5 [ 23123 ] | |
| Affects Version/s | 10.6 [ 24028 ] |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.7 [ 24805 ] |
| Affects Version/s | 10.7 [ 24805 ] |
| Link |
This issue is blocked by |
| Fix Version/s | 10.2 [ 14601 ] |
| Labels | race |
| Affects Version/s | 10.11 [ 27614 ] |
| Status | Open [ 1 ] | Confirmed [ 10101 ] |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Assignee | Nayuta Yanagisawa [ JIRAUSER47117 ] | Yuchen Pei [ JIRAUSER52627 ] |
| Fix Version/s | 10.7 [ 24805 ] |
| Fix Version/s | 10.8 [ 26121 ] | |
| Fix Version/s | 10.9 [ 26905 ] | |
| Fix Version/s | 10.10 [ 27530 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.0 [ 28320 ] | |
| Fix Version/s | 11.1 [ 28549 ] |
| Status | Confirmed [ 10101 ] | In Progress [ 3 ] |
| Summary | spiders' background initialization causes conflicts with mysql-upgrade (and general improvements) | Improve spider init queries to fix spider init bugs |
| Link |
This issue is blocked by |
| Link |
This issue blocks |
| Link |
This issue blocks |
| Link | This issue relates to MDEV-27998 [ MDEV-27998 ] |
| Fix Version/s | 10.3 [ 22126 ] |
| Fix Version/s | 10.8 [ 26121 ] |
| Link | This issue relates to MDEV-28553 [ MDEV-28553 ] |
| Link |
This issue blocks |
| Link |
This issue blocks |
| Summary | Improve spider init queries to fix spider init bugs | Simplify spider init queries |
| Assignee | Yuchen Pei [ JIRAUSER52627 ] | Alexey Botchkov [ holyfoot ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Link | This issue relates to MDEV-19850 [ MDEV-19850 ] |
| Assignee | Alexey Botchkov [ holyfoot ] | Yuchen Pei [ JIRAUSER52627 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Link |
This issue is blocked by |
| Link |
This issue relates to |
| Link |
This issue is part of |
| Link |
This issue is blocked by |
| Fix Version/s | N/A [ 14700 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Fix Version/s | 10.5 [ 23123 ] | |
| Fix Version/s | 10.6 [ 24028 ] | |
| Fix Version/s | 10.9 [ 26905 ] | |
| Fix Version/s | 10.10 [ 27530 ] | |
| Fix Version/s | 10.11 [ 27614 ] | |
| Fix Version/s | 11.0 [ 28320 ] | |
| Fix Version/s | 11.1 [ 28549 ] | |
| Resolution | Duplicate [ 3 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Link |
This issue relates to |