Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document.
The most striking example is EXPLAIN FORMAT=JSON:
{
|
"query_block": {
|
"select_id": 1,
|
"table": {
|
"table_name": "table",
|
...
|
},
|
"table": {
|
...
|
The solution has two parts:
Part #1: Follow the MDEV-23766 approach and make debug build generate assertion failures.
Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output.
As for which version to fix this in: The problem with EXPLAIN FORMAT=JSON output is present from the very early versions (10.1). However, the fix will cause a lot of changes in EXPLAIN FORMAT=JSON output (the changes will be dummy but they will be there). This may not be desirable for older versions. Because of that, for now I'm setting fixVersion to 10.8.
A question to be resolved: how to modify EXPLAIN/ANALYZE to make them well-formed JSON? Should we wrap them into an array, like MySQL does or do something else?)
{"report":{"fcp":782.5,"ttfb":193.20000000298023,"pageVisibility":"visible","entityId":105005,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"54e9c1ea-c562-4498-8936-5d942b0c3fab","navigationType":0,"readyForUser":854.2000000029802,"redirectCount":0,"resourceLoadedEnd":895.5,"resourceLoadedStart":228.60000000149012,"resourceTiming":[{"duration":7.199999995529652,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":228.60000000149012,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":228.60000000149012,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":235.79999999701977,"responseStart":0,"secureConnectionStart":0},{"duration":9.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":228.89999999850988,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":228.89999999850988,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":238.39999999850988,"responseStart":0,"secureConnectionStart":0},{"duration":63.899999998509884,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":229.10000000149012,"connectEnd":229.10000000149012,"connectStart":229.10000000149012,"domainLookupEnd":229.10000000149012,"domainLookupStart":229.10000000149012,"fetchStart":229.10000000149012,"redirectEnd":0,"redirectStart":0,"requestStart":229.10000000149012,"responseEnd":293,"responseStart":293,"secureConnectionStart":229.10000000149012},{"duration":165.69999999552965,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":229.20000000298023,"connectEnd":229.20000000298023,"connectStart":229.20000000298023,"domainLookupEnd":229.20000000298023,"domainLookupStart":229.20000000298023,"fetchStart":229.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":229.20000000298023,"responseEnd":394.8999999985099,"responseStart":394.8999999985099,"secureConnectionStart":229.20000000298023},{"duration":169.39999999850988,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":229.60000000149012,"connectEnd":229.60000000149012,"connectStart":229.60000000149012,"domainLookupEnd":229.60000000149012,"domainLookupStart":229.60000000149012,"fetchStart":229.60000000149012,"redirectEnd":0,"redirectStart":0,"requestStart":229.60000000149012,"responseEnd":399,"responseStart":399,"secureConnectionStart":229.60000000149012},{"duration":171,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":229.70000000298023,"connectEnd":229.70000000298023,"connectStart":229.70000000298023,"domainLookupEnd":229.70000000298023,"domainLookupStart":229.70000000298023,"fetchStart":229.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":229.70000000298023,"responseEnd":400.70000000298023,"responseStart":400.70000000298023,"secureConnectionStart":229.70000000298023},{"duration":172.60000000149012,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":229.89999999850988,"connectEnd":229.89999999850988,"connectStart":229.89999999850988,"domainLookupEnd":229.89999999850988,"domainLookupStart":229.89999999850988,"fetchStart":229.89999999850988,"redirectEnd":0,"redirectStart":0,"requestStart":229.89999999850988,"responseEnd":402.5,"responseStart":402.5,"secureConnectionStart":229.89999999850988},{"duration":204.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":230.10000000149012,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":230.10000000149012,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":434.6000000014901,"responseStart":0,"secureConnectionStart":0},{"duration":174.29999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":230.20000000298023,"connectEnd":230.20000000298023,"connectStart":230.20000000298023,"domainLookupEnd":230.20000000298023,"domainLookupStart":230.20000000298023,"fetchStart":230.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":230.20000000298023,"responseEnd":404.5,"responseStart":404.5,"secureConnectionStart":230.20000000298023},{"duration":204.40000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":230.29999999701977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":230.29999999701977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":434.70000000298023,"responseStart":0,"secureConnectionStart":0},{"duration":176,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":230.5,"connectEnd":230.5,"connectStart":230.5,"domainLookupEnd":230.5,"domainLookupStart":230.5,"fetchStart":230.5,"redirectEnd":0,"redirectStart":0,"requestStart":230.5,"responseEnd":406.5,"responseStart":406.5,"secureConnectionStart":230.5},{"duration":266.79999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":231.70000000298023,"connectEnd":231.70000000298023,"connectStart":231.70000000298023,"domainLookupEnd":231.70000000298023,"domainLookupStart":231.70000000298023,"fetchStart":231.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":231.70000000298023,"responseEnd":498.5,"responseStart":498.3999999985099,"secureConnectionStart":231.70000000298023},{"duration":267.30000000447035,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":231.79999999701977,"connectEnd":231.79999999701977,"connectStart":231.79999999701977,"domainLookupEnd":231.79999999701977,"domainLookupStart":231.79999999701977,"fetchStart":231.79999999701977,"redirectEnd":0,"redirectStart":0,"requestStart":231.79999999701977,"responseEnd":499.1000000014901,"responseStart":499.1000000014901,"secureConnectionStart":231.79999999701977},{"duration":20.700000002980232,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":445.8999999985099,"connectEnd":445.8999999985099,"connectStart":445.8999999985099,"domainLookupEnd":445.8999999985099,"domainLookupStart":445.8999999985099,"fetchStart":445.8999999985099,"redirectEnd":0,"redirectStart":0,"requestStart":445.8999999985099,"responseEnd":466.6000000014901,"responseStart":466.6000000014901,"secureConnectionStart":445.8999999985099},{"duration":22.700000002980232,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":477,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":477,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":499.70000000298023,"responseStart":0,"secureConnectionStart":0},{"duration":22.19999999552965,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2bv2/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":477.70000000298023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":477.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":499.8999999985099,"responseStart":0,"secureConnectionStart":0},{"duration":410.8999999985099,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":478.5,"connectEnd":478.5,"connectStart":478.5,"domainLookupEnd":478.5,"domainLookupStart":478.5,"fetchStart":478.5,"redirectEnd":0,"redirectStart":0,"requestStart":478.5,"responseEnd":889.3999999985099,"responseStart":889.3999999985099,"secureConnectionStart":478.5},{"duration":415,"initiatorType":"script","name":"https://jira.mariadb.org/s/53a43b6764f587426c7bb9a150184c00-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":479,"connectEnd":479,"connectStart":479,"domainLookupEnd":479,"domainLookupStart":479,"fetchStart":479,"redirectEnd":0,"redirectStart":0,"requestStart":479,"responseEnd":894,"responseStart":894,"secureConnectionStart":479},{"duration":416.20000000298023,"initiatorType":"script","name":"https://jira.mariadb.org/s/630dda803a823fdd5771c4338338e018-CDN/lu2bv2/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":479.29999999701977,"connectEnd":479.29999999701977,"connectStart":479.29999999701977,"domainLookupEnd":479.29999999701977,"domainLookupStart":479.29999999701977,"fetchStart":479.29999999701977,"redirectEnd":0,"redirectStart":0,"requestStart":479.29999999701977,"responseEnd":895.5,"responseStart":895.5,"secureConnectionStart":479.29999999701977},{"duration":284.1000000014901,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":566.3999999985099,"connectEnd":566.3999999985099,"connectStart":566.3999999985099,"domainLookupEnd":566.3999999985099,"domainLookupStart":566.3999999985099,"fetchStart":566.3999999985099,"redirectEnd":0,"redirectStart":0,"requestStart":566.3999999985099,"responseEnd":850.5,"responseStart":850.5,"secureConnectionStart":566.3999999985099},{"duration":135.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":774.7999999970198,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":774.7999999970198,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":910.2999999970198,"responseStart":0,"secureConnectionStart":0}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":21,"responseStart":194,"responseEnd":197,"domLoading":227,"domInteractive":912,"domContentLoadedEventStart":912,"domContentLoadedEventEnd":952,"domComplete":1319,"loadEventStart":1319,"loadEventEnd":1320,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":892.1000000014901},{"name":"bigPipe.sidebar-id.end","time":892.7999999970198},{"name":"bigPipe.activity-panel-pipe-id.start","time":893},{"name":"bigPipe.activity-panel-pipe-id.end","time":895.3999999985099},{"name":"activityTabFullyLoaded","time":960.1000000014901}],"measures":[],"correlationId":"4273f516aad115","effectiveType":"4g","downlink":9,"rtt":0,"serverDuration":109,"dbReadsTimeInMs":16,"dbConnsTimeInMs":25,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}