Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document.
The most striking example is EXPLAIN FORMAT=JSON:
{
|
"query_block": {
|
"select_id": 1,
|
"table": {
|
"table_name": "table",
|
...
|
},
|
"table": {
|
...
|
The solution has two parts:
Part #1: Follow the MDEV-23766 approach and make debug build generate assertion failures.
Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output.
As for which version to fix this in: The problem with EXPLAIN FORMAT=JSON output is present from the very early versions (10.1). However, the fix will cause a lot of changes in EXPLAIN FORMAT=JSON output (the changes will be dummy but they will be there). This may not be desirable for older versions. Because of that, for now I'm setting fixVersion to 10.8.
A question to be resolved: how to modify EXPLAIN/ANALYZE to make them well-formed JSON? Should we wrap them into an array, like MySQL does or do something else?)
{"report":{"fcp":775,"ttfb":124.5,"pageVisibility":"visible","entityId":105005,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"0f8fc7d0-152c-4f35-a4b4-8c579787a6fc","navigationType":0,"readyForUser":846.7999999523163,"redirectCount":0,"resourceLoadedEnd":885.2999999523163,"resourceLoadedStart":129.59999990463257,"resourceTiming":[{"duration":147.60000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":129.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":129.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":277.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":147.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":129.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":129.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":277.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":157.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":129.89999985694885,"connectEnd":129.89999985694885,"connectStart":129.89999985694885,"domainLookupEnd":129.89999985694885,"domainLookupStart":129.89999985694885,"fetchStart":129.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":129.89999985694885,"responseEnd":287.39999985694885,"responseStart":287.39999985694885,"secureConnectionStart":129.89999985694885},{"duration":288.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":130.09999990463257,"connectEnd":130.09999990463257,"connectStart":130.09999990463257,"domainLookupEnd":130.09999990463257,"domainLookupStart":130.09999990463257,"fetchStart":130.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":130.09999990463257,"responseEnd":418.89999985694885,"responseStart":418.89999985694885,"secureConnectionStart":130.09999990463257},{"duration":292.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":130.20000004768372,"connectEnd":130.20000004768372,"connectStart":130.20000004768372,"domainLookupEnd":130.20000004768372,"domainLookupStart":130.20000004768372,"fetchStart":130.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":130.20000004768372,"responseEnd":422.7999999523163,"responseStart":422.7999999523163,"secureConnectionStart":130.20000004768372},{"duration":293.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":130.20000004768372,"connectEnd":130.20000004768372,"connectStart":130.20000004768372,"domainLookupEnd":130.20000004768372,"domainLookupStart":130.20000004768372,"fetchStart":130.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":130.20000004768372,"responseEnd":423.2999999523163,"responseStart":423.2999999523163,"secureConnectionStart":130.20000004768372},{"duration":293.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":130.29999995231628,"connectEnd":130.29999995231628,"connectStart":130.29999995231628,"domainLookupEnd":130.29999995231628,"domainLookupStart":130.29999995231628,"fetchStart":130.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":130.29999995231628,"responseEnd":423.7000000476837,"responseStart":423.7000000476837,"secureConnectionStart":130.29999995231628},{"duration":295,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":130.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":130.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":425.39999985694885,"responseStart":0,"secureConnectionStart":0},{"duration":293.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":130.59999990463257,"connectEnd":130.59999990463257,"connectStart":130.59999990463257,"domainLookupEnd":130.59999990463257,"domainLookupStart":130.59999990463257,"fetchStart":130.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":130.59999990463257,"responseEnd":424.2999999523163,"responseStart":424.2999999523163,"secureConnectionStart":130.59999990463257},{"duration":295,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":130.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":130.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":425.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":294.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":130.79999995231628,"connectEnd":130.79999995231628,"connectStart":130.79999995231628,"domainLookupEnd":130.79999995231628,"domainLookupStart":130.79999995231628,"fetchStart":130.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":130.79999995231628,"responseEnd":424.89999985694885,"responseStart":424.89999985694885,"secureConnectionStart":130.79999995231628},{"duration":666.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":136.29999995231628,"connectEnd":136.29999995231628,"connectStart":136.29999995231628,"domainLookupEnd":136.29999995231628,"domainLookupStart":136.29999995231628,"fetchStart":136.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":136.29999995231628,"responseEnd":803.2000000476837,"responseStart":803.2000000476837,"secureConnectionStart":136.29999995231628},{"duration":667.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":136.5,"connectEnd":136.5,"connectStart":136.5,"domainLookupEnd":136.5,"domainLookupStart":136.5,"fetchStart":136.5,"redirectEnd":0,"redirectStart":0,"requestStart":136.5,"responseEnd":803.7999999523163,"responseStart":803.7999999523163,"secureConnectionStart":136.5},{"duration":178.10000014305115,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":441.09999990463257,"connectEnd":441.09999990463257,"connectStart":441.09999990463257,"domainLookupEnd":441.09999990463257,"domainLookupStart":441.09999990463257,"fetchStart":441.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":441.09999990463257,"responseEnd":619.2000000476837,"responseStart":619.2000000476837,"secureConnectionStart":441.09999990463257},{"duration":107.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":697.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":697.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":804.8999998569489,"responseStart":0,"secureConnectionStart":0},{"duration":144.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":698.5999999046326,"connectEnd":698.5999999046326,"connectStart":698.5999999046326,"domainLookupEnd":698.5999999046326,"domainLookupStart":698.5999999046326,"fetchStart":698.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":698.5999999046326,"responseEnd":843.3999998569489,"responseStart":843.3999998569489,"secureConnectionStart":698.5999999046326},{"duration":186.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/f51ef5507eea4c158f257c66c93b2a3f-CDN/lu2bu7/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":699,"connectEnd":699,"connectStart":699,"domainLookupEnd":699,"domainLookupStart":699,"fetchStart":699,"redirectEnd":0,"redirectStart":0,"requestStart":699,"responseEnd":885.2999999523163,"responseStart":885.2000000476837,"secureConnectionStart":699}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":3,"responseStart":124,"responseEnd":132,"domLoading":128,"domInteractive":913,"domContentLoadedEventStart":913,"domContentLoadedEventEnd":961,"domComplete":1832,"loadEventStart":1832,"loadEventEnd":1833,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":881.3999998569489},{"name":"bigPipe.sidebar-id.end","time":882},{"name":"bigPipe.activity-panel-pipe-id.start","time":882.2000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":884.5},{"name":"activityTabFullyLoaded","time":969.7999999523163}],"measures":[],"correlationId":"6268f0d2008b","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":69,"dbReadsTimeInMs":12,"dbConnsTimeInMs":18,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}