Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.4(EOL)
-
None
Description
Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document.
The most striking example is EXPLAIN FORMAT=JSON:
{
|
"query_block": {
|
"select_id": 1,
|
"table": {
|
"table_name": "table",
|
...
|
},
|
"table": {
|
...
|
The solution has two parts:
Part #1: Follow the MDEV-23766 approach and make debug build generate assertion failures.
Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output.
As for which version to fix this in: The problem with EXPLAIN FORMAT=JSON output is present from the very early versions (10.1). However, the fix will cause a lot of changes in EXPLAIN FORMAT=JSON output (the changes will be dummy but they will be there). This may not be desirable for older versions. Because of that, for now I'm setting fixVersion to 10.8.
A question to be resolved: how to modify EXPLAIN/ANALYZE to make them well-formed JSON? Should we wrap them into an array, like MySQL does or do something else?)
Attachments
Issue Links
- causes
-
-
- Closed
-
-
-
- Closed
-
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Sergei Krivonos [ JIRAUSER49805 ] |
| Link |
This issue relates to |
| Fix Version/s | 10.4 [ 22408 ] |
| Description |
Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document. The most striking example is EXPLAIN FORMAT=JSON: {code:json} { "query_block": { "select_id": 1, "table": { "table_name": "table", ... }, "table": { ... {code} |
Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document. The most striking example is EXPLAIN FORMAT=JSON: {code:json} { "query_block": { "select_id": 1, "table": { "table_name": "table", ... }, "table": { ... {code} The solution has two parts: Part #1: Follow the Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output. |
| Fix Version/s | 10.8 [ 26121 ] | |
| Fix Version/s | 10.4 [ 22408 ] |
| Description |
Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document. The most striking example is EXPLAIN FORMAT=JSON: {code:json} { "query_block": { "select_id": 1, "table": { "table_name": "table", ... }, "table": { ... {code} The solution has two parts: Part #1: Follow the Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output. |
Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document. The most striking example is EXPLAIN FORMAT=JSON: {code:json} { "query_block": { "select_id": 1, "table": { "table_name": "table", ... }, "table": { ... {code} The solution has two parts: Part #1: Follow the Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output. As for which version to fix this in: The problem with EXPLAIN FORMAT=JSON output is present from the very early versions (10.1). However, the fix will cause a lot of changes in EXPLAIN FORMAT=JSON output (the changes will be dummy but they will be there). This may not be desirable for older versions. Because of that, for now I'm setting fixVersion to 10.8. |
| Description |
Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document. The most striking example is EXPLAIN FORMAT=JSON: {code:json} { "query_block": { "select_id": 1, "table": { "table_name": "table", ... }, "table": { ... {code} The solution has two parts: Part #1: Follow the Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output. As for which version to fix this in: The problem with EXPLAIN FORMAT=JSON output is present from the very early versions (10.1). However, the fix will cause a lot of changes in EXPLAIN FORMAT=JSON output (the changes will be dummy but they will be there). This may not be desirable for older versions. Because of that, for now I'm setting fixVersion to 10.8. |
Json_writer code allows one to write multiple members with the same name in a JSON object.
This is likely to prevent proper processing of the created document. The most striking example is EXPLAIN FORMAT=JSON: {code:json} { "query_block": { "select_id": 1, "table": { "table_name": "table", ... }, "table": { ... {code} The solution has two parts: Part #1: Follow the Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output. As for which version to fix this in: The problem with EXPLAIN FORMAT=JSON output is present from the very early versions (10.1). However, the fix will cause a lot of changes in EXPLAIN FORMAT=JSON output (the changes will be dummy but they will be there). This may not be desirable for older versions. Because of that, for now I'm setting fixVersion to 10.8. A question to be resolved: how to modify EXPLAIN/ANALYZE to make them well-formed JSON? Should we wrap them into an array, like MySQL does or do something else?) |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Sergei Krivonos [ JIRAUSER49805 ] | Sergei Petrunia [ psergey ] |
| Status | In Progress [ 3 ] | In Review [ 10002 ] |
| Assignee | Sergei Petrunia [ psergey ] | Sergei Krivonos [ JIRAUSER49805 ] |
| Attachment | mdev_24760.txt [ 60860 ] |
| Attachment | mdev_24760.txt [ 60861 ] |
| Attachment | mdev_24760-1.txt [ 60862 ] |
| Attachment | mdev_24760-1.txt [ 60862 ] |
| Attachment | mdev_24760.txt [ 60861 ] |
| Attachment | mdev_24760.txt [ 60860 ] |
| Sprint | 10.4.0-1 [ 254 ] |
| Rank | Ranked higher |
| Sprint | 10.4.0-1 [ 254 ] |
| Rank | Ranked higher |
| Assignee | Sergei Krivonos [ JIRAUSER49805 ] | Sergei Petrunia [ psergey ] |
| Assignee | Sergei Petrunia [ psergey ] | Sergei Krivonos [ JIRAUSER49805 ] |
| Status | In Review [ 10002 ] | Stalled [ 10000 ] |
| Fix Version/s | 10.8.0 [ 26800 ] | |
| Fix Version/s | 10.8 [ 26121 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Stalled [ 10000 ] | Closed [ 6 ] |
| Epic Link |
|
| Workflow | MariaDB v3 [ 127408 ] | MariaDB v4 [ 159840 ] |
| Link |
This issue causes |
| Link |
This issue causes |