Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-27036

Json_writer allows one to create duplicate object members

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.4(EOL)
    • 10.8.0
    • Optimizer
    • None

    Description

      Json_writer code allows one to write multiple members with the same name in a JSON object.

      This is likely to prevent proper processing of the created document.

      The most striking example is EXPLAIN FORMAT=JSON:

      {
      		 
        "query_block": {
      		 
          "select_id": 1,
      		 
          "table": {
      		 
            "table_name": "table",
      		 
            ...
      		 
          },
      		 
           "table": {
      		 
            ...

      The solution has two parts:

      Part #1: Follow the MDEV-23766 approach and make debug build generate assertion failures.

      Part #2: Fix EXPLAIN FORMAT=JSON code to not produce such invalid (or valid but not processable) JSON output.

      As for which version to fix this in: The problem with EXPLAIN FORMAT=JSON output is present from the very early versions (10.1). However, the fix will cause a lot of changes in EXPLAIN FORMAT=JSON output (the changes will be dummy but they will be there). This may not be desirable for older versions. Because of that, for now I'm setting fixVersion to 10.8.

      A question to be resolved: how to modify EXPLAIN/ANALYZE to make them well-formed JSON? Should we wrap them into an array, like MySQL does or do something else?)

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27204 [ERROR] Json_writer: a member name was expected, Assertion `got_name == named_item_expected()' failed

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-27206 [ERROR] Duplicated key: cause, Assertion `is_uniq_key' failed with optimizer trace

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23766 Optimizer tracing code is prone to producing invalid JSON

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            sergei.krivonos Sergei Krivonos (Inactive) added a comment -

            tests to fix in bb-10.8-MDEV-27036:
            ./mysql-test-run main.innodb_ext_key main.rowid_filter_innodb main.cte_recursive main.order_by json.json_table main.explain_json_format_partitions main.derived_cond_pushdown main.opt_trace main.win main.intersect_all main.except main.except_all main.explain_json main.subselect_cache main.rowid_filter main.analyze_format_json main.having_cond_pushdown main.set_operation main.subselect_no_semijoin main.intersect json.json_table_mysql main.analyze_stmt_orderby main.explain_json_innodb main.join_cache main.range main.range_mrr_icp

            sergei.krivonos Sergei Krivonos (Inactive) added a comment - tests to fix in bb-10.8- MDEV-27036 : ./mysql-test-run main.innodb_ext_key main.rowid_filter_innodb main.cte_recursive main.order_by json.json_table main.explain_json_format_partitions main.derived_cond_pushdown main.opt_trace main.win main.intersect_all main.except main.except_all main.explain_json main.subselect_cache main.rowid_filter main.analyze_format_json main.having_cond_pushdown main.set_operation main.subselect_no_semijoin main.intersect json.json_table_mysql main.analyze_stmt_orderby main.explain_json_innodb main.join_cache main.range main.range_mrr_icp
            sergei.krivonos Sergei Krivonos (Inactive) added a comment -

            https://buildbot.mariadb.org/#/grid?branch=bb-10.8-MDEV-27036

            sergei.krivonos Sergei Krivonos (Inactive) added a comment - https://buildbot.mariadb.org/#/grid?branch=bb-10.8-MDEV-27036
            marko Marko Mäkelä added a comment -

            Is there a 10.5 version of this? The 10.4 version that was already pushed causes a merge conflict in 10.5 for some constructor parameters.

            marko Marko Mäkelä added a comment - Is there a 10.5 version of this? The 10.4 version that was already pushed causes a merge conflict in 10.5 for some constructor parameters.
            sergei.krivonos Sergei Krivonos (Inactive) added a comment -

            marko,
            merged 10.4 into 10.5 https://buildbot.mariadb.org/#/grid?branch=bb-10.5-MDEV-23766
            psergei,
            do you think we could just rebase this on 10.5 as well?
            Thanks

            sergei.krivonos Sergei Krivonos (Inactive) added a comment - marko , merged 10.4 into 10.5 https://buildbot.mariadb.org/#/grid?branch=bb-10.5-MDEV-23766 psergei , do you think we could just rebase this on 10.5 as well? Thanks
            psergei Sergei Petrunia added a comment -

            Ok to push the latest contents of bb-10.8-MDEV-27036, after one thing is fixed: do not disable the unit test.

            psergei Sergei Petrunia added a comment - Ok to push the latest contents of bb-10.8- MDEV-27036 , after one thing is fixed: do not disable the unit test.

            People

              sergei.krivonos Sergei Krivonos (Inactive)
              psergei Sergei Petrunia
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.