[MDEV-26573] An improper locking bug due to unreleased lock in the ds_archive.cc - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Trivial
Resolution: Fixed
Affects Version/s: 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5, 10.6
Fix Version/s: 10.2.41, 10.3.32, 10.4.22, 10.5.13, 10.6.5
Component/s: Server
Labels:
- code
- performance
- server
Environment:
All

Description

The lock archive_ctxt->mutex is not released correctly when archive_ctxt->dest_file == NULL in the function archive_open?

https://github.com/MariaDB/server/blob/76f4a78ba2639b5abd01a88b24a3c509c11530ce/extra/mariabackup/ds_archive.cc#L168-L175

Also mentioned in ~~MDEV-26556~~.

Attachments

Activity

Ascending order - Click to sort in descending order

Vladislav Vaintroub added a comment - 2021-09-15 12:07

Ok, that code is not compiled.

Vladislav Vaintroub added a comment - 2021-09-15 12:07 Ok, that code is not compiled.

Ryan added a comment - 2021-09-15 12:16

@wlad Should be a real bug? Once it is included and compiled in MariaDB.

Ryan added a comment - 2021-09-15 12:16 @wlad Should be a real bug? Once it is included and compiled in MariaDB.

Vladislav Vaintroub added a comment - 2021-09-15 13:17 - edited

it is not compiled. Otherwise, you would point me to the place where ds_archive.cc is compiled, as it would be part of either ADD_LIBRARY or ADD_EXECUTABLE in CMakeLists.txt . it is not there, it is not compiled.
If it was compiled , ds_archive.cc would be somewhere in here https://github.com/MariaDB/server/blob/10.6/extra/mariabackup/CMakeLists.txt#L62

but it is not compiled. So I removed it entirely

Vladislav Vaintroub added a comment - 2021-09-15 13:17 - edited it is not compiled. Otherwise, you would point me to the place where ds_archive.cc is compiled, as it would be part of either ADD_LIBRARY or ADD_EXECUTABLE in CMakeLists.txt . it is not there, it is not compiled. If it was compiled , ds_archive.cc would be somewhere in here https://github.com/MariaDB/server/blob/10.6/extra/mariabackup/CMakeLists.txt#L62 but it is not compiled. So I removed it entirely

Ryan added a comment - 2021-09-15 13:30

OK, thanks

Ryan added a comment - 2021-09-15 13:30 OK, thanks

People

Assignee:: Vladislav Vaintroub

Reporter:: Ryan

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2021-09-08 09:23

Updated:: 2021-09-15 13:30

Resolved:: 2021-09-15 13:23

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server