[MDEV-26538] Incorrect error condition check for ReadFile (named pipes) - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.6, 10.7(EOL)
Fix Version/s: 10.6.5
Component/s: Platform Windows, Server
Labels:
None

Description

in threadpool_winsockets.cc

      /* Do async read (named pipe) */

    if (ReadFile(m_handle, buf.buf, buf.len, 0, &m_overlapped))

      err= GetLastError();

That should be "if (!ReadFile...)". ReadFile returns TRUE on success, FALSE on error

Attachments

Activity

People

Assignee:: Vladislav Vaintroub

Reporter:: Vladislav Vaintroub

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2021-09-04 16:36

Updated:: 2021-09-05 08:06

Resolved:: 2021-09-05 08:06

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.