[#MDEV-26538] Incorrect error condition check for ReadFile (named pipes)

[MDEV-26538] Incorrect error condition check for ReadFile (named pipes) Created: 2021-09-04 Updated: 2021-09-05 Resolved: 2021-09-05
Status:	Closed
Project:	MariaDB Server
Component/s:	Platform Windows, Server
Affects Version/s:	10.6, 10.7
Fix Version/s:	10.6.5

Type:

Bug

Priority:

Major

Reporter:

Vladislav Vaintroub

Assignee:

Vladislav Vaintroub

Resolution:

Fixed

Votes:

Labels:

None

Description

in threadpool_winsockets.cc

      /* Do async read (named pipe) */

    if (ReadFile(m_handle, buf.buf, buf.len, 0, &m_overlapped))

      err= GetLastError();

That should be "if (!ReadFile...)". ReadFile returns TRUE on success, FALSE on error

Generated at Thu Feb 08 09:46:03 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.