Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26438

cmake < 3.6.0 produced RPMs with invalid names

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.5
    • 10.5.13
    • Packaging
    • None

    Description

      RPMs created by cmake 2.8.12.2 on Centos-7, note missing version:

      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-backup.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-client.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-common.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-devel.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-server.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-shared.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-test.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-columnstore-engine.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-connect-engine.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-cracklib-password-check.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-gssapi-server.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-oqgraph-engine.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-rocksdb-engine.rpm generated.
      		 
      CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-s3-engine.rpm generated.

      internal version is set properly:

      [abychko@centos-7-abychko server]$ rpm -qp MariaDB--centos74-x86_64-client.rpm --qf %{version}-%{release}
      		 
      10.5.13-1.el7

      main CMakeLists.txt contains CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12), so 2.8.12.2 must produce RPMs with well-formed names

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          abychko Alexey Bychko (Inactive) created issue -
          abychko Alexey Bychko (Inactive) made changes -
          Field Original Value New Value
          Assignee Alexey Bychko [ abychko ]
          abychko Alexey Bychko (Inactive) made changes -
          Summary RPMs created with cmake 2.8 produced with invalid names cmake 2.8 produced RPMs with invalid names
          serg Sergei Golubchik made changes -
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          abychko Alexey Bychko (Inactive) added a comment - - edited

          exactly the same issue here: https://cmake.org/pipermail/cmake/2013-October/056011.html

          if CPACK_* variables are used before INCLUDE(CPack) - they will be empty because they are set at the end from CPack.cmake.
          the most simple way is to use VERSION variable from cmake/mysql_version.cmake like it's done in 10.4 or set CPACK_RPM_PACKAGE_VERSION to VERSION

          abychko Alexey Bychko (Inactive) added a comment - - edited exactly the same issue here: https://cmake.org/pipermail/cmake/2013-October/056011.html if CPACK_* variables are used before INCLUDE(CPack) - they will be empty because they are set at the end from CPack.cmake. the most simple way is to use VERSION variable from cmake/mysql_version.cmake like it's done in 10.4 or set CPACK_RPM_PACKAGE_VERSION to VERSION
          abychko Alexey Bychko (Inactive) made changes -
          Summary cmake 2.8 produced RPMs with invalid names cmake < 3.6.0 produced RPMs with invalid names
          abychko Alexey Bychko (Inactive) added a comment -

          it's fixed in 4b6ef03dcda608109f0455732ab9ed65f32b06bb
          but there is another issue, it will be reported separately

          abychko Alexey Bychko (Inactive) added a comment - it's fixed in 4b6ef03dcda608109f0455732ab9ed65f32b06bb but there is another issue, it will be reported separately
          abychko Alexey Bychko (Inactive) made changes -
          issue.field.resolutiondate 2021-08-27 08:37:49.0 2021-08-27 08:37:49.337
          abychko Alexey Bychko (Inactive) made changes -
          Fix Version/s 10.5.13 [ 26026 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 124452 ] MariaDB v4 [ 159619 ]

          People

            abychko Alexey Bychko (Inactive)
            abychko Alexey Bychko (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.