[MDEV-26438] cmake < 3.6.0 produced RPMs with invalid names Created: 2021-08-19  Updated: 2021-08-27  Resolved: 2021-08-27

Status: Closed
Project: MariaDB Server
Component/s: Packaging
Affects Version/s: 10.5
Fix Version/s: 10.5.13

Type: Bug Priority: Major
Reporter: Alexey Bychko (Inactive) Assignee: Alexey Bychko (Inactive)
Resolution: Fixed Votes: 0
Labels: None


 Description   

RPMs created by cmake 2.8.12.2 on Centos-7, note missing version:

CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-backup.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-client.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-common.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-devel.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-server.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-shared.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-test.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-columnstore-engine.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-connect-engine.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-cracklib-password-check.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-gssapi-server.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-oqgraph-engine.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-rocksdb-engine.rpm generated.
 
CPack: - package: /home/abychko/server/MariaDB--centos74-x86_64-s3-engine.rpm generated.

internal version is set properly:

[abychko@centos-7-abychko server]$ rpm -qp MariaDB--centos74-x86_64-client.rpm --qf %{version}-%{release}
 
10.5.13-1.el7

main CMakeLists.txt contains CMAKE_MINIMUM_REQUIRED(VERSION 2.8.12), so 2.8.12.2 must produce RPMs with well-formed names

 Comments   
Comment by Alexey Bychko (Inactive) [ 2021-08-26 ]

exactly the same issue here: https://cmake.org/pipermail/cmake/2013-October/056011.html

if CPACK_* variables are used before INCLUDE(CPack) - they will be empty because they are set at the end from CPack.cmake.
the most simple way is to use VERSION variable from cmake/mysql_version.cmake like it's done in 10.4 or set CPACK_RPM_PACKAGE_VERSION to VERSION

Comment by Alexey Bychko (Inactive) [ 2021-08-27 ]

it's fixed in 4b6ef03dcda608109f0455732ab9ed65f32b06bb
but there is another issue, it will be reported separately

Generated at Thu Feb 08 09:45:19 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.