Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26376

pars_info_bind_id() unnecessarily copies strings

    XMLWordPrintable

    Details

      Description

      The function pars_info_bind_id() is unnecessarily copying string keys. Not only is the parameter copy_name always being passed as nonzero, but that parameter could actually have always been specified as zero. For all calls except one, a compile-time constant string is being passed as a parameter. For the call in fts_get_select_columns_str() and fts_doc_fetch_by_doc_id(), the passed string will already be allocated from the same memory heap that pars_info_bind_id() is using.

        Attachments

          Activity

            People

            Assignee:
            marko Marko Mäkelä
            Reporter:
            marko Marko Mäkelä
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Git Integration