After the following commit:
commit 1748a31ae8d69e4939336f644f884e9de3039e7f
|
Author: Marko Mäkelä <marko.makela@mariadb.com>
|
Date: Tue Jul 3 15:10:06 2018 +0300
|
MDEV-16675 Unnecessary explicit lock acquisition during UPDATE or DELETE
|
|
lock_rec_convert_impl_to_expl() does not create explicit lock if the caller holds implicit lock.
Suppose we have the following call stack:
▾ lock_rec_convert_impl_to_expl
|
▾ lock_clust_rec_read_check_and_lock
|
▾ sel_set_rec_lock
|
▸ row_search_mvcc
|
If lock type is LOCK_GAP or LOCK_ORDINARY, and the transaction holds implicit lock for the record, then explicit gap-lock will not be set for the record, as lock_rec_convert_impl_to_expl() returns true and lock_rec_convert_impl_to_expl() bypasses lock_rec_lock() call.
The following test shows the issue:
--source include/have_innodb.inc
|
--source include/count_sessions.inc
|
CREATE TABLE t(a INT UNSIGNED PRIMARY KEY) ENGINE=InnoDB;
|
INSERT INTO t VALUES (10), (30);
|
--connect (con1,localhost,root,,)
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
BEGIN;
|
INSERT INTO t VALUES (20);
|
SELECT * FROM t WHERE a BETWEEN 10 AND 30;
|
--connection default
|
SET session innodb_lock_wait_timeout=1;
|
--error ER_LOCK_WAIT_TIMEOUT
|
INSERT INTO t VALUES (15);
|
--disconnect con1
|
DROP TABLE t;
|
--source include/wait_until_count_sessions.inc
|
{"report":{"fcp":1291.5,"ttfb":415.19999998807907,"pageVisibility":"visible","entityId":101418,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"31f3b504-98f5-4e75-9bad-29ee489bf4b1","navigationType":0,"readyForUser":1384.3999999761581,"redirectCount":0,"resourceLoadedEnd":1756.7999999821186,"resourceLoadedStart":420.7999999821186,"resourceTiming":[{"duration":191.40000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":420.7999999821186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":420.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":612.1999999880791,"responseStart":0,"secureConnectionStart":0},{"duration":191.30000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":421.19999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":421.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":612.5,"responseStart":0,"secureConnectionStart":0},{"duration":257.09999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":421.2999999821186,"connectEnd":421.2999999821186,"connectStart":421.2999999821186,"domainLookupEnd":421.2999999821186,"domainLookupStart":421.2999999821186,"fetchStart":421.2999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":421.2999999821186,"responseEnd":678.3999999761581,"responseStart":678.3999999761581,"secureConnectionStart":421.2999999821186},{"duration":542.1999999880791,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":421.5,"connectEnd":421.5,"connectStart":421.5,"domainLookupEnd":421.5,"domainLookupStart":421.5,"fetchStart":421.5,"redirectEnd":0,"redirectStart":0,"requestStart":421.5,"responseEnd":963.6999999880791,"responseStart":963.6999999880791,"secureConnectionStart":421.5},{"duration":546.0999999940395,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":421.69999998807907,"connectEnd":421.69999998807907,"connectStart":421.69999998807907,"domainLookupEnd":421.69999998807907,"domainLookupStart":421.69999998807907,"fetchStart":421.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":421.69999998807907,"responseEnd":967.7999999821186,"responseStart":967.7999999821186,"secureConnectionStart":421.69999998807907},{"duration":546.3000000119209,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":421.89999997615814,"connectEnd":421.89999997615814,"connectStart":421.89999997615814,"domainLookupEnd":421.89999997615814,"domainLookupStart":421.89999997615814,"fetchStart":421.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":421.89999997615814,"responseEnd":968.1999999880791,"responseStart":968.1999999880791,"secureConnectionStart":421.89999997615814},{"duration":546.6999999880791,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":422.09999999403954,"connectEnd":422.09999999403954,"connectStart":422.09999999403954,"domainLookupEnd":422.09999999403954,"domainLookupStart":422.09999999403954,"fetchStart":422.09999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":422.09999999403954,"responseEnd":968.7999999821186,"responseStart":968.6999999880791,"secureConnectionStart":422.09999999403954},{"duration":547.3000000119209,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":422.2999999821186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":422.2999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":969.5999999940395,"responseStart":0,"secureConnectionStart":0},{"duration":546.8000000119209,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":422.39999997615814,"connectEnd":422.39999997615814,"connectStart":422.39999997615814,"domainLookupEnd":422.39999997615814,"domainLookupStart":422.39999997615814,"fetchStart":422.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":422.39999997615814,"responseEnd":969.1999999880791,"responseStart":969.1999999880791,"secureConnectionStart":422.39999997615814},{"duration":547.0999999940395,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":422.59999999403954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":422.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":969.6999999880791,"responseStart":0,"secureConnectionStart":0},{"duration":547,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":422.7999999821186,"connectEnd":422.7999999821186,"connectStart":422.7999999821186,"domainLookupEnd":422.7999999821186,"domainLookupStart":422.7999999821186,"fetchStart":422.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":422.7999999821186,"responseEnd":969.7999999821186,"responseStart":969.7999999821186,"secureConnectionStart":422.7999999821186},{"duration":1227.699999988079,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":423.69999998807907,"connectEnd":423.69999998807907,"connectStart":423.69999998807907,"domainLookupEnd":423.69999998807907,"domainLookupStart":423.69999998807907,"fetchStart":423.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":423.69999998807907,"responseEnd":1651.3999999761581,"responseStart":1651.3999999761581,"secureConnectionStart":423.69999998807907},{"duration":1329,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":427.7999999821186,"connectEnd":427.7999999821186,"connectStart":427.7999999821186,"domainLookupEnd":427.7999999821186,"domainLookupStart":427.7999999821186,"fetchStart":427.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":427.7999999821186,"responseEnd":1756.7999999821186,"responseStart":1756.7999999821186,"secureConnectionStart":427.7999999821186},{"duration":823.8000000119209,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":827.1999999880791,"connectEnd":827.1999999880791,"connectStart":827.1999999880791,"domainLookupEnd":827.1999999880791,"domainLookupStart":827.1999999880791,"fetchStart":827.1999999880791,"redirectEnd":0,"redirectStart":0,"requestStart":827.1999999880791,"responseEnd":1651,"responseStart":1651,"secureConnectionStart":827.1999999880791}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":260,"responseStart":415,"responseEnd":421,"domLoading":419,"domInteractive":1781,"domContentLoadedEventStart":1781,"domContentLoadedEventEnd":1824,"domComplete":3452,"loadEventStart":3452,"loadEventEnd":3453,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1759.5},{"name":"bigPipe.sidebar-id.end","time":1760.5999999940395},{"name":"bigPipe.activity-panel-pipe-id.start","time":1760.699999988079},{"name":"bigPipe.activity-panel-pipe-id.end","time":1763.2999999821186},{"name":"activityTabFullyLoaded","time":1831.2999999821186}],"measures":[],"correlationId":"83404f2ccc528","effectiveType":"4g","downlink":9.4,"rtt":0,"serverDuration":94,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}