Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26138

innodb_flush_log_at_trx_commit=3 doesn't flush

Details

    Description

      "Since 10.2 this code was refactored to have switches in descending
      order, so value of 3 for innodb_flush_log_at_trx_commit is behaving
      the same as value of 2, that is no FSYNC is being enforced during
      COMMIT phase. The switch should however not be empty and cases 2 and 3
      should not have the identical contents."

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-232 Remove one fsync() inside engine's commit() method

          • Major - Major loss of function.
          • Closed
          links to

          Web Link gh pr 1873

          Activity

            Ascending order - Click to sort in descending order
            danblack Daniel Black created issue -
            danblack Daniel Black made changes -
            Field Original Value New Value
            marko Marko Mäkelä added a comment -

            The parameter value 3 was introduced in MDEV-232, and it has been effectively treated as innodb_flush_log_at_trx_commit=2 since the MariaDB 10.2.2 alpha release.

            Would an alternative fix be acceptable? That is, let us remove the value 3 and have the server issue a warning that the value was clamped to 2? That would basically document the status quo. Does anyone really need the innodb_flush_log_at_trx_commit=3 behaviour that was introduced in MDEV-232?

            3 (flush to disk at prepare and at commit, slower and usually redundant)

            marko Marko Mäkelä added a comment - The parameter value 3 was introduced in MDEV-232 , and it has been effectively treated as innodb_flush_log_at_trx_commit=2 since the MariaDB 10.2.2 alpha release. Would an alternative fix be acceptable? That is, let us remove the value 3 and have the server issue a warning that the value was clamped to 2? That would basically document the status quo. Does anyone really need the innodb_flush_log_at_trx_commit=3 behaviour that was introduced in MDEV-232 ? 3 (flush to disk at prepare and at commit, slower and usually redundant)
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Assignee Thirunarayanan Balathandayuthapani [ thiru ] Andrei Elkin [ elkin ]
            marko Marko Mäkelä made changes -
            Affects Version/s 10.5.0 [ 23709 ]
            Affects Version/s 10.4.0 [ 23115 ]
            Affects Version/s 10.3.0 [ 22127 ]
            Affects Version/s 10.2.2 [ 22013 ]
            marko Marko Mäkelä added a comment -

            Because the documentation string for innodb_flush_log_at_trx_commit implies that the value 3 is ‘stronger’ than the value 1, it would seem wrong to keep treating it in a similar way as the ‘weaker’ value 2.

            Overall, it seems to be simplest to fix the parameter to work as documented.

            marko Marko Mäkelä added a comment - Because the documentation string for innodb_flush_log_at_trx_commit implies that the value 3 is ‘stronger’ than the value 1, it would seem wrong to keep treating it in a similar way as the ‘weaker’ value 2. Overall, it seems to be simplest to fix the parameter to work as documented.
            marko Marko Mäkelä made changes -
            Assignee Andrei Elkin [ elkin ] Marko Mäkelä [ marko ]
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2021-07-23 14:49:25.0 2021-07-23 14:49:25.817
            marko Marko Mäkelä made changes -
            Fix Version/s 10.2.40 [ 26027 ]
            Fix Version/s 10.3.31 [ 26028 ]
            Fix Version/s 10.4.21 [ 26030 ]
            Fix Version/s 10.5.12 [ 26025 ]
            Fix Version/s 10.6.4 [ 26033 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 123436 ] MariaDB v4 [ 159504 ]

            People

              marko Marko Mäkelä
              danblack Daniel Black
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.