The bug was originally observed as hanging binlog background thread at shutdown similar to one of MDEV-21120:
#14 MYSQL_BIN_LOG::stop_background_thread (this=0x55660e6b9ba0 <mysql_bin_log>) at /data/Server/10.6D/sql/log.cc:3411
#15 0x000055660af0ff8e in close_connections () at /data/Server/10.6D/sql/mysqld.cc:1720
#16 0x000055660af215bc in mysqld_main (argc=44, argv=<optimized out>) at /data/Server/10.6D/sql/mysqld.cc:5839
The hang suggested a missed unlogging of a xid or signal notification to the thread loss.
It turns out the former is the case. MDEV-21117 commit reveals an in-born two defects in MYSQL_BIN_LOG::write_transaction_to_binlog 's loop that marks event groups
with the need of explicit xid unlogging:
(1) the loop never expected to start from already
reset ha_info (which is the one phase commit case that does not need the unlogging) as well as
(2) had a logical flaw
in its continuatio... condition to break after the first iteration snubbing any
further ha_info in the list even if they might represent commit_checkpoint_request incapable engines - which would meant to mark the group which may not have happen on the first iteration.
I set to fix starting from 10.2 though 10.6 is the most vulnerable due to (1) - the loop marks groups that should not be.
Setting to a blocker as a big part of the problem is a regression highly visible at least in concurrent tests on 10.6.
Elena Stepanova
added a comment - Setting to a blocker as a big part of the problem is a regression highly visible at least in concurrent tests on 10.6.
390014781b6 pushed to 10.6. 10.2-10.5 vulnerability has much lesser chances and will be addressed with backporting the 10.6 patch.
Andrei Elkin
added a comment - 390014781b6 pushed to 10.6. 10.2-10.5 vulnerability has much lesser chances and will be addressed with backporting the 10.6 patch.
People
Andrei Elkin
Andrei Elkin
Votes:
0Vote for this issue
Watchers:
4Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
{"report":{"fcp":771.5,"ttfb":173,"pageVisibility":"visible","entityId":100850,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"aa60bd88-e501-48f0-81c5-3165a9046b94","navigationType":0,"readyForUser":838.5999999046326,"redirectCount":0,"resourceLoadedEnd":502.2999999523163,"resourceLoadedStart":181.69999980926514,"resourceTiming":[{"duration":29,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":181.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":181.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":210.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":30.799999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":181.89999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":181.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":212.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":186.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":182.09999990463257,"connectEnd":182.09999990463257,"connectStart":182.09999990463257,"domainLookupEnd":182.09999990463257,"domainLookupStart":182.09999990463257,"fetchStart":182.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":219.59999990463257,"responseEnd":368.5,"responseStart":239,"secureConnectionStart":182.09999990463257},{"duration":319.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":182.5,"connectEnd":182.5,"connectStart":182.5,"domainLookupEnd":182.5,"domainLookupStart":182.5,"fetchStart":182.5,"redirectEnd":0,"redirectStart":0,"requestStart":220.19999980926514,"responseEnd":502.2999999523163,"responseStart":241.89999985694885,"secureConnectionStart":182.5},{"duration":63.700000047683716,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":182.59999990463257,"connectEnd":182.59999990463257,"connectStart":182.59999990463257,"domainLookupEnd":182.59999990463257,"domainLookupStart":182.59999990463257,"fetchStart":182.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":221.59999990463257,"responseEnd":246.29999995231628,"responseStart":242.5,"secureConnectionStart":182.59999990463257},{"duration":66.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":182.69999980926514,"connectEnd":182.69999980926514,"connectStart":182.69999980926514,"domainLookupEnd":182.69999980926514,"domainLookupStart":182.69999980926514,"fetchStart":182.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":223.39999985694885,"responseEnd":249.39999985694885,"responseStart":246.69999980926514,"secureConnectionStart":182.69999980926514},{"duration":70,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":182.79999995231628,"connectEnd":182.79999995231628,"connectStart":182.79999995231628,"domainLookupEnd":182.79999995231628,"domainLookupStart":182.79999995231628,"fetchStart":182.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":224.69999980926514,"responseEnd":252.79999995231628,"responseStart":249.69999980926514,"secureConnectionStart":182.79999995231628},{"duration":39.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":183,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":183,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":222.5,"responseStart":0,"secureConnectionStart":0},{"duration":70.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":183,"connectEnd":183,"connectStart":183,"domainLookupEnd":183,"domainLookupStart":183,"fetchStart":183,"redirectEnd":0,"redirectStart":0,"requestStart":225.19999980926514,"responseEnd":253.19999980926514,"responseStart":250.19999980926514,"secureConnectionStart":183},{"duration":42,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":183.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":183.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":225.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":78.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":183.19999980926514,"connectEnd":183.19999980926514,"connectStart":183.19999980926514,"domainLookupEnd":183.19999980926514,"domainLookupStart":183.19999980926514,"fetchStart":183.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":230.59999990463257,"responseEnd":261.89999985694885,"responseStart":260.5,"secureConnectionStart":183.19999980926514},{"duration":281.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":186.89999985694885,"connectEnd":186.89999985694885,"connectStart":186.89999985694885,"domainLookupEnd":186.89999985694885,"domainLookupStart":186.89999985694885,"fetchStart":186.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":260.09999990463257,"responseEnd":468.19999980926514,"responseStart":465.2999999523163,"secureConnectionStart":186.89999985694885},{"duration":288.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":187,"connectEnd":187,"connectStart":187,"domainLookupEnd":187,"domainLookupStart":187,"fetchStart":187,"redirectEnd":0,"redirectStart":0,"requestStart":302.19999980926514,"responseEnd":475.19999980926514,"responseStart":470.2999999523163,"secureConnectionStart":187},{"duration":148,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":519,"connectEnd":519,"connectStart":519,"domainLookupEnd":519,"domainLookupStart":519,"fetchStart":519,"redirectEnd":0,"redirectStart":0,"requestStart":634.8999998569489,"responseEnd":667,"responseStart":665.5999999046326,"secureConnectionStart":519},{"duration":237.70000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":725.3999998569489,"connectEnd":725.3999998569489,"connectStart":725.3999998569489,"domainLookupEnd":725.3999998569489,"domainLookupStart":725.3999998569489,"fetchStart":725.3999998569489,"redirectEnd":0,"redirectStart":0,"requestStart":930.7999999523163,"responseEnd":963.0999999046326,"responseStart":962.0999999046326,"secureConnectionStart":725.3999998569489},{"duration":167,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":763.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":763.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":930.7999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":37,"responseStart":173,"responseEnd":186,"domLoading":176,"domInteractive":923,"domContentLoadedEventStart":923,"domContentLoadedEventEnd":970,"domComplete":1330,"loadEventStart":1330,"loadEventEnd":1331,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":901.5},{"name":"bigPipe.sidebar-id.end","time":902.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.start","time":902.3999998569489},{"name":"bigPipe.activity-panel-pipe-id.end","time":903.7999999523163},{"name":"activityTabFullyLoaded","time":988}],"measures":[],"correlationId":"c237ebc0e79ff0","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":73,"dbReadsTimeInMs":14,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Setting to a blocker as a big part of the problem is a regression highly visible at least in concurrent tests on 10.6.