[MDEV-26031] unnessary xid logging in one phase commit case Created: 2021-06-28 Updated: 2022-08-15 Resolved: 2021-06-29 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Replication |
| Affects Version/s: | 10.2, 10.3, 10.4, 10.5, 10.6 |
| Fix Version/s: | 10.6.3 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Andrei Elkin | Assignee: | Andrei Elkin |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
The bug was originally observed as hanging binlog background thread at shutdown similar to one of MDEV-21120:
The hang suggested a missed unlogging of a xid or signal notification to the thread loss. It turns out the former is the case. I set to fix starting from 10.2 though 10.6 is the most vulnerable due to (1) - the loop marks groups that should not be. Thanks to elenst, alice and marko who helped to identify it! |
| Comments |
| Comment by Elena Stepanova [ 2021-06-28 ] |
|
Setting to a blocker as a big part of the problem is a regression highly visible at least in concurrent tests on 10.6. |
| Comment by Andrei Elkin [ 2021-06-28 ] |
|
I also asked serg to review on slack. |
| Comment by Sujatha Sivakumar (Inactive) [ 2021-06-29 ] |
|
Hello Andrei, Thanks for working on this issue. Changes look good to me. |
| Comment by Andrei Elkin [ 2021-06-29 ] |
|
390014781b6 pushed to 10.6. 10.2-10.5 vulnerability has much lesser chances and will be addressed with backporting the 10.6 patch. |