Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25863

Connect : Replace __WIN__ by _WIN32

    XMLWordPrintable

    Details

      Description

      Connect engine , makes a lot of use of __WIN__ preprocessor constant
      It should be replaced by the standard _WIN32 (always defined, on any Windows, including _WIN64, by any compiler see https://bugs.mysql.com/bug.php?id=20338 and MDEV-25602 for more info.

      The reason why it is not in the scope of MDEV-25602 is that Connect is an external component, usually maintained outside of core MariaDB, and thus this change should in the "upstream" repository.

      one easy way way to do such a replacement is

      cd storage/connect
      git grep -l '__WIN__' . | xargs sed -i 's/__WIN__/_WIN32/g'
      

      from a Linux bash.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              bertrandop Olivier Bertrand
              Reporter:
              wlad Vladislav Vaintroub
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: