Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25863

Connect : Replace __WIN__ by _WIN32

Details

    Description

      Connect engine , makes a lot of use of __WIN__ preprocessor constant
      It should be replaced by the standard _WIN32 (always defined, on any Windows, including _WIN64, by any compiler see https://bugs.mysql.com/bug.php?id=20338 and MDEV-25602 for more info.

      The reason why it is not in the scope of MDEV-25602 is that Connect is an external component, usually maintained outside of core MariaDB, and thus this change should in the "upstream" repository.

      one easy way way to do such a replacement is

      cd storage/connect
      		 
      git grep -l '__WIN__' . | xargs sed -i 's/__WIN__/_WIN32/g'

      from a Linux bash.

      Attachments

        Issue Links

          is part of

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25602 MySQL bug# 20338 : get rid of __WIN__ in favor of standard _WIN32

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-25861 POSIX Namespace reserves "_t" suffix; MariaDB code conflicts with this.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            People

              bertrandop Olivier Bertrand
              wlad Vladislav Vaintroub
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.