[MDEV-25863] Connect : Replace __WIN__ by _WIN32 Created: 2021-06-06  Updated: 2021-06-09  Resolved: 2021-06-09

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Connect
Affects Version/s: 10.2, 10.3, 10.4, 10.5, 10.6
Fix Version/s: 10.6.2, 10.2.39, 10.3.30, 10.4.20, 10.5.11

Type: Bug Priority: Major
Reporter: Vladislav Vaintroub Assignee: Olivier Bertrand
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
PartOf
is part of MDEV-25602 MySQL bug# 20338 : get rid of __WIN__... Closed
Relates
relates to MDEV-25861 POSIX Namespace reserves "_t" suffix;... Open

 Description   

Connect engine , makes a lot of use of __WIN__ preprocessor constant
It should be replaced by the standard _WIN32 (always defined, on any Windows, including _WIN64, by any compiler see https://bugs.mysql.com/bug.php?id=20338 and MDEV-25602 for more info.

The reason why it is not in the scope of MDEV-25602 is that Connect is an external component, usually maintained outside of core MariaDB, and thus this change should in the "upstream" repository.

one easy way way to do such a replacement is

cd storage/connect
 
git grep -l '__WIN__' . | xargs sed -i 's/__WIN__/_WIN32/g'

from a Linux bash.

 Comments   
Comment by Olivier Bertrand [ 2021-06-09 ]

Just one replace action under Visual Studio

Generated at Thu Feb 08 09:40:58 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.