Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24915

Galera conflict resolution is unnecessarily complex

Details

    Description

      The fix of MDEV-23328 introduced a background thread for killing conflicting transactions. In 10.6, thanks to the refactoring that was conducted in MDEV-24671, the high-priority ("brute-force") applier thread can kill the conflicting transactions itself, before waiting for the locks to be finally released (after the conflicting transactions have been rolled back), in the lock_wait() function.

      This will also allow us to remove the Galera hack LockGGuard that had to be added in MDEV-20612, and remove Galera-related function parameters from lock creation.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23328 Server hang due to Galera lock conflict resolution

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18534 galera_sr.GCF-1018B: Test failure: mysqltest: mysqltest: Can't connect to local MySQL server; signal 6

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-20612 Improve InnoDB lock_sys scalability

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24671 Assertion failure in lock_wait_table_reserve_slot()

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24967 Signal 11 on ha_innodb.cc::bg_wsrep_kill_trx line 18611

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24966 Galera multi-master regression

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25114 Crash: WSREP: invalid state ROLLED_BACK (FATAL)

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Description The fix of MDEV-23328 introduced a background thread for killing conflicting transactions. In 10.6, thanks to the refactoring that was conducted in MDEV-24671, we can simply kill those transactions in the high-priority ("brute-force") applier thread that seeks to break those locks by aborting the transactions that hold the conflicting locks, in the {{lock_wait()}} function.

            This will also allow us to remove the Galera hack {{LockGGuard}} that had to be added in MDEV-20612, and remove Galera-related function parameters from lock creation.             		The fix of MDEV-23328 introduced a background thread for killing conflicting transactions. In 10.6, thanks to the refactoring that was conducted in MDEV-24671, the high-priority ("brute-force") applier thread can kill the conflicting transactions itself, before waiting for the locks to be finally released (after the conflicting transactions have been rolled back), in the {{lock_wait()}} function.

            This will also allow us to remove the Galera hack {{LockGGuard}} that had to be added in MDEV-20612, and remove Galera-related function parameters from lock creation.
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2021-02-18 14:25:52.0 2021-02-18 14:25:52.908
            marko Marko Mäkelä made changes -
            Fix Version/s 10.6.0 [ 24431 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            jplindst Jan Lindström (Inactive) made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 119278 ] MariaDB v4 [ 158923 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.